fix: sonar coverage#2765
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses Sonar coverage failures after a merge by expanding unit tests to exercise previously untested UI interactions in the frontend components.
Changes:
- Updated
NotFoundtests to mock router navigation consistently and verify “Back Home” triggers navigation. - Updated
Dashboardtests to cover opening/closing the row-details modal, including async rendering after data load.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| frontend/src/components/tests/NotFound.test.tsx | Adds navigation mock + click interaction test to improve coverage of the NotFound “Back Home” behavior. |
| frontend/src/components/tests/Dashboard.test.tsx | Adds modal open/close interaction test (async) to improve Dashboard UI coverage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
DerekRoberts
approved these changes
Jun 14, 2026
DerekRoberts
left a comment
DerekRoberts
left a comment
Member
There was a problem hiding this comment.
Thanks for the hand! It's appreciated. 😊
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After main merge sonar was reporting failure, this PR is to fix that.
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: