Skip to content

fix: sonar failure#2766

Merged
mishraomp merged 1 commit into
mainfrom
chore/sonar-coverage-exclusion-fe
Jun 14, 2026
Merged

fix: sonar failure#2766
mishraomp merged 1 commit into
mainfrom
chore/sonar-coverage-exclusion-fe

Conversation

@mishraomp

@mishraomp mishraomp commented Jun 14, 2026

Copy link
Copy Markdown
Collaborator

the last PR #2765 missed one exclusion.

The file that is auto generated by tanstack.

this PR fixes that by adding it to sonar ignore list for frontend and also update the deprecated import.


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

Copilot AI review requested due to automatic review settings June 14, 2026 18:17

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR resolves a SonarCloud failure by excluding the TanStack-generated route tree file from frontend Sonar analysis and updates the Vite TanStack router plugin import to the non-deprecated API.

Changes:

  • Exclude routeTree.gen.ts from the frontend SonarCloud scan to avoid analysis failures on autogenerated code.
  • Update Vite config to use the current tanstackRouter import/call from @tanstack/router-plugin/vite.
  • Minor formatting normalization in vite.config.ts (single-line alias and deprecation list).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
frontend/vite.config.ts Switches to the updated TanStack router Vite plugin API and applies small formatting adjustments.
.github/workflows/analysis.yml Adds **/routeTree.gen.ts to frontend Sonar exclusions to prevent failures caused by autogenerated output.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mishraomp mishraomp requested a review from DerekRoberts June 14, 2026 18:25
@mishraomp mishraomp self-assigned this Jun 14, 2026
@mishraomp mishraomp enabled auto-merge (squash) June 14, 2026 18:34
@github-project-automation github-project-automation Bot moved this from New to Waiting in DevOps (NR) Jun 14, 2026
@mishraomp mishraomp merged commit 5426a0b into main Jun 14, 2026
37 of 39 checks passed
@mishraomp mishraomp deleted the chore/sonar-coverage-exclusion-fe branch June 14, 2026 19:52
@github-project-automation github-project-automation Bot moved this from Waiting to Done in DevOps (NR) Jun 14, 2026
@mishraomp

mishraomp commented Jun 14, 2026

Copy link
Copy Markdown
Collaborator Author

thanks @DerekRoberts now this looks perfect with all green in main merge pipeline.
image

@DerekRoberts

Copy link
Copy Markdown
Member

Thanks again @mishraomp! It's good to have you back. 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants