Skip to content

Commit 33bcd33

Browse files
authored
Implement Minions no longer need accuracy (PathOfBuildingCommunity#1193)
* Give minions "CannotBeEvaded" by default * Add `nil` check to "Precise Technique" processing "Precise Technique" was causing issues for `output.Accuracy = nil` when checking against minion accuracy values. (Arguably it shouldn't check at all unless there is reason to) --------- Co-authored-by: majochem <majochem@users.noreply.github.com>
1 parent 58d2776 commit 33bcd33

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

src/Modules/CalcOffence.lua

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2420,7 +2420,7 @@ function calcs.offence(env, actor, activeSkill)
24202420

24212421
-- Check Precise Technique Keystone condition per pass as MH/OH might have different values
24222422
local condName = pass.label:gsub(" ", "") .. "AccRatingHigherThanMaxLife"
2423-
skillModList.conditions[condName] = output.Accuracy > env.player.output.Life
2423+
skillModList.conditions[condName] = ( output.Accuracy and output.Accuracy or 0 ) > env.player.output.Life
24242424

24252425
-- Calculate attack/cast speed
24262426
if activeSkill.activeEffect.grantedEffect.castTime == 0 and not skillData.castTimeOverride and not skillData.triggered then

src/Modules/CalcPerform.lua

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -895,7 +895,8 @@ function calcs.perform(env, skipEHP)
895895
if modDB:Flag(nil, "MinionAccuracyEqualsAccuracy") then
896896
env.minion.modDB:NewMod("Accuracy", "BASE", calcLib.val(modDB, "Accuracy") + calcLib.val(modDB, "Dex") * (modDB:Override(nil, "DexAccBonusOverride") or data.misc.AccuracyPerDexBase), "Player")
897897
else
898-
env.minion.modDB:NewMod("Accuracy", "BASE", round(env.data.monsterAccuracyTable[env.minion.level] * (env.minion.minionData.accuracy or 1)) + data.playerMinionIntrinsicStats["accuracy_rating_per_level"] * (env.minion.level - 1), "Base")
898+
-- Minions no longer need Accuracy as of patch 0.3.0
899+
env.minion.modDB:NewMod("CannotBeEvaded", "FLAG", 1, "Minion Attacks always hit")
899900
end
900901
env.minion.modDB:NewMod("CritMultiplier", "BASE", env.data.monsterConstants["base_critical_hit_damage_bonus"] + env.data.playerMinionIntrinsicStats["base_critical_hit_damage_bonus"], "Base")
901902
env.minion.modDB:NewMod("FireResist", "BASE", env.minion.minionData.fireResist, "Base")

0 commit comments

Comments
 (0)