Fix Tier 3 code review findings

Author: bdcbqa314159

plugin_arch/DynamicPluginAdapter.hpp

@@ -112,6 +112,10 @@ class DynamicPluginAdapter : public IPlugin,
     return lib_->has(func_name);
   }
 
+  // WARNING: function_count and functions come from the plugin — the framework
+  // cannot validate that function_count matches the actual array length.
+  // Callers iterating functions must not trust function_count blindly if the
+  // plugin source is untrusted.
   [[nodiscard]] const PluginDescriptor& descriptor() const { return *desc_; }
 
   [[nodiscard]] const std::shared_ptr<DynamicLibrary>& library() const {

plugin_arch/EventBus.hpp

@@ -29,6 +29,14 @@ namespace plugin_arch {
 
 class EventBus {
  public:
+  EventBus() = default;
+  ~EventBus() = default;
+
+  EventBus(const EventBus&) = delete;
+  EventBus& operator=(const EventBus&) = delete;
+  EventBus(EventBus&&) = default;
+  EventBus& operator=(EventBus&&) = default;
+
   using Handler = std::function<void(const std::string& topic,
                                      const std::string& payload)>;
   using SubscriptionId = std::size_t;
@@ -117,7 +125,7 @@ class EventBus {
     }
   }
 
-  // --- Vetoable API (B5) ---
+  // --- Vetoable API ---
 
   // Subscribe a veto handler. Returns true to allow, false to veto.
   // Higher priority = checked first.

plugin_arch/HotPluginLoader.hpp

@@ -8,7 +8,6 @@
 #pragma once
 
 #include <filesystem>
-#include <iostream>
 #include <memory>
 #include <string>
 
@@ -47,9 +46,7 @@ class HotPluginLoader {
       try {
         reload();
         return true;
-      } catch (const std::exception& e) {
-        std::cerr << "[HotPluginLoader] reload failed: " << e.what()
-                  << " — keeping current version\n";
+      } catch (const std::exception&) {
         last_modified_ = mtime;  // avoid retrying every poll
         return false;
       }

plugin_arch/PluginManager.hpp

@@ -304,6 +304,14 @@ inline void apply_config_defaults(IPlugin* instance, PluginConfig& config) {
 
 class PluginManager {
  public:
+  PluginManager() = default;
+  ~PluginManager() = default;
+
+  PluginManager(const PluginManager&) = delete;
+  PluginManager& operator=(const PluginManager&) = delete;
+  PluginManager(PluginManager&&) = delete;
+  PluginManager& operator=(PluginManager&&) = delete;
+
   // Per-plugin configuration, keyed by plugin name.
   using ConfigMap = std::unordered_map<std::string, PluginConfig>;
 
@@ -869,7 +877,7 @@ class PluginManager {
   // after built-in mixin injection (configure, service locator, event bus) and
   // before on_init(). Allows hosts to wire custom mixins without modifying
   // PluginManager source.
-  using MixinWirer = std::function<void(std::shared_ptr<IPlugin>&)>;
+  using MixinWirer = std::function<void(const std::shared_ptr<IPlugin>&)>;
 
   void add_mixin_wirer(MixinWirer wirer) {
     if (wirer) custom_wirers_.push_back(std::move(wirer));
@@ -1213,7 +1221,7 @@ class PluginManager {
 
   // Wire all opt-in mixins on an instance.
   // Order: validate+configure → inject services → inject events → custom wirers → init.
-  void wire_instance(std::shared_ptr<IPlugin>& instance,
+  void wire_instance(const std::shared_ptr<IPlugin>& instance,
                      const PluginEntry& entry, const ConfigMap& config_map,
                      bool skip_validation = false) {
     auto resolved = resolve_plugin_config(

plugin_arch/PluginRegistry.hpp

@@ -51,6 +51,14 @@ struct ErrorRecord {
 
 class PluginRegistry {
  public:
+  PluginRegistry() = default;
+  ~PluginRegistry() = default;
+
+  PluginRegistry(const PluginRegistry&) = delete;
+  PluginRegistry& operator=(const PluginRegistry&) = delete;
+  PluginRegistry(PluginRegistry&&) = default;
+  PluginRegistry& operator=(PluginRegistry&&) = default;
+
   // Scan a directory for shared libraries and probe each one for metadata.
   // Appends to existing entries, so you can scan multiple directories.
   // Returns the number of new plugins discovered in this call.

plugin_arch/ServiceLocator.hpp

@@ -19,6 +19,14 @@ namespace plugin_arch {
 
 class ServiceLocator {
  public:
+  ServiceLocator() = default;
+  ~ServiceLocator() = default;
+
+  ServiceLocator(const ServiceLocator&) = delete;
+  ServiceLocator& operator=(const ServiceLocator&) = delete;
+  ServiceLocator(ServiceLocator&&) = default;
+  ServiceLocator& operator=(ServiceLocator&&) = default;
+
   // Register a loaded plugin as a service.
   // The locator holds a weak reference — it does not extend the plugin's lifetime.
   void add(const std::shared_ptr<IPlugin>& service) {