Fix MSVC visibility in crash_diagnostic bad_plugins

Author: bdcbqa314159

examples/crash_diagnostic/bad_plugins/crash_in_constructor.cpp

@@ -1,8 +1,17 @@
 // Bad plugin #1: crashes during construction (inside allocator).
 // Simulates a library that segfaults when the app tries to instantiate it.
 
+// Bad plugin #1: crashes during construction (inside allocator).
+// Simulates a library that segfaults when the app tries to instantiate it.
+
 #include <stdexcept>
 
+#if defined(_WIN32)
+  #define BAD_EXPORT __declspec(dllexport)
+#else
+  #define BAD_EXPORT __attribute__((visibility("default")))
+#endif
+
 class CrashInConstructor {
  public:
   CrashInConstructor() {
@@ -11,9 +20,6 @@ class CrashInConstructor {
 };
 
 extern "C" {
-  __attribute__((visibility("default")))
-  CrashInConstructor* allocator() { return new CrashInConstructor(); }
-
-  __attribute__((visibility("default")))
-  void deallocator(CrashInConstructor* ptr) { delete ptr; }
+  BAD_EXPORT CrashInConstructor* allocator() { return new CrashInConstructor(); }
+  BAD_EXPORT void deallocator(CrashInConstructor* ptr) { delete ptr; }
 }

examples/crash_diagnostic/bad_plugins/crash_on_load.cpp

@@ -2,8 +2,17 @@
 // A global/static constructor runs during library loading and fails.
 // This is the hardest to debug because it happens inside dlopen() itself.
 
+// Bad plugin #3: crashes at dlopen time, before any symbol is resolved.
+// A global/static constructor runs during library loading and fails.
+
 #include <stdexcept>
 
+#if defined(_WIN32)
+  #define BAD_EXPORT __declspec(dllexport)
+#else
+  #define BAD_EXPORT __attribute__((visibility("default")))
+#endif
+
 static int bad_init() {
   throw std::runtime_error("static init failed: cannot connect to server");
   return 0;
@@ -18,9 +27,6 @@ class CrashOnLoad {
 };
 
 extern "C" {
-  __attribute__((visibility("default")))
-  CrashOnLoad* allocator() { return new CrashOnLoad(); }
-
-  __attribute__((visibility("default")))
-  void deallocator(CrashOnLoad* ptr) { delete ptr; }
+  BAD_EXPORT CrashOnLoad* allocator() { return new CrashOnLoad(); }
+  BAD_EXPORT void deallocator(CrashOnLoad* ptr) { delete ptr; }
 }