Skip to content

chore(php-lol): update nginx to 1.30.1 #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
Closed

chore(php-lol): update nginx to 1.30.1 #324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
291c41f
chore(php-lol): update nginx to 1.30.1
Copilot May 15, 2026
24e2ce3
test(php-lol): assert nginx version in structure test
Copilot May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dockerfiles/php-lol/Dockerfile.8.1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ FROM php:8.1.34-fpm-bookworm AS foundation
ENV \
APP_DIR=/usr/src/app \
LIBMAXMINDDB_VERSION=1.7.1 \
NGINX_VERSION=1.28.2 \
NGINX_VERSION=1.30.1 \
NGX_HTTP_GEOIP2_MODULE_VERSION=3.4 \
VERSION=8.1.34

Expand Down
2 changes: 1 addition & 1 deletion dockerfiles/php-lol/Dockerfile.8.2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ FROM php:8.2.31-fpm-bookworm@sha256:141b21da3978112cb85c84381fbc3d1fce94adbf23a6
ENV \
APP_DIR=/usr/src/app \
LIBMAXMINDDB_VERSION=1.7.1 \
NGINX_VERSION=1.28.2 \
NGINX_VERSION=1.30.1 \

@bdossantos bdossantos May 15, 2026

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot apply changes based on this feedback

Copilot AI May 15, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implemented in 24e2ce3: updated tests/php-lol.yaml to add a container-structure test that asserts /usr/sbin/nginx -v reports nginx/1.30.1, so CI now validates the nginx version after this bump.

NGX_HTTP_GEOIP2_MODULE_VERSION=3.4 \
VERSION=8.2.31

Expand Down
2 changes: 1 addition & 1 deletion dockerfiles/php-lol/Dockerfile.8.3
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ FROM php:8.3.31-fpm-bookworm@sha256:04734f92937d2796855c5482bc289265f67b89f6c7d3
ENV \
APP_DIR=/usr/src/app \
LIBMAXMINDDB_VERSION=1.7.1 \
NGINX_VERSION=1.28.2 \
NGINX_VERSION=1.30.1 \
NGX_HTTP_GEOIP2_MODULE_VERSION=3.4 \
VERSION=8.3.31

Expand Down
2 changes: 1 addition & 1 deletion dockerfiles/php-lol/Dockerfile.8.4
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ FROM php:8.4.21-fpm-bookworm@sha256:a85533f56d2e904d5fc88b28f5af2019d4116dac15be
ENV \
APP_DIR=/usr/src/app \
LIBMAXMINDDB_VERSION=1.7.1 \
NGINX_VERSION=1.28.2 \
NGINX_VERSION=1.30.1 \
NGX_HTTP_GEOIP2_MODULE_VERSION=3.4 \
VERSION=8.4.21

Expand Down
7 changes: 7 additions & 0 deletions tests/php-lol.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,13 @@ commandTests:
- 'nginx: the configuration file /etc/nginx/nginx.conf syntax is ok'
- 'nginx: configuration file /etc/nginx/nginx.conf test is successful'

- name: 'nginx version is 1.30.1'
command: '/usr/sbin/nginx'
args: ['-v']
exitCode: 0
expectedError:
- 'nginx version: nginx/1.30.1'

- name: 'amqp extension is installed'
command: 'sh'
args: ['-c', 'php -m | grep -i amqp']
Expand Down