Skip to content

Support named tuples and arrow serialization#41

Open
haberdashPI wants to merge 15 commits into
mainfrom
dfl/onda-pirating
Open

Support named tuples and arrow serialization#41
haberdashPI wants to merge 15 commits into
mainfrom
dfl/onda-pirating

Conversation

@haberdashPI

Copy link
Copy Markdown
Member

These two features were pirated in another beacon repo, and are being moved here

Comment thread Project.toml Outdated
uuid = "bb34ddd2-327f-4c4a-bfb0-c98fc494ece1"
authors = ["Beacon Biosignals, Inc."]
version = "0.3.1"
version = "0.4.0"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is breaking?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the slack conversation we do want to be careful about how this is introduced re the pirated methods removed in beacon-biosignals/Onda.jl#126

Comment thread src/TimeSpans.jl Outdated
Comment thread src/TimeSpans.jl Outdated
Comment thread Project.toml Outdated
Comment thread test/runtests.jl Outdated
Comment thread README.md Outdated
Comment thread Project.toml
Co-authored-by: Alex Arslan <ararslan@comcast.net>
@haberdashPI haberdashPI linked an issue Jul 12, 2022 that may be closed by this pull request
Comment thread test/runtests.jl Outdated
Co-authored-by: Eric Hanson <5846501+ericphanson@users.noreply.github.com>
@haberdashPI
haberdashPI requested a review from ericphanson July 12, 2022 14:15
@haberdashPI

Copy link
Copy Markdown
Member Author

@ericphanson: I believe this is ready for you to approve.

@haberdashPI

Copy link
Copy Markdown
Member Author

Though there is some debate over in #42 about whether TimeSpans should support non Period values at all...

@haberdashPI

Copy link
Copy Markdown
Member Author

Okay. I think that should be safe enough now...

Comment thread src/TimeSpans.jl Outdated
Comment thread src/TimeSpans.jl
Comment thread src/TimeSpans.jl
@ericphanson

Copy link
Copy Markdown
Member

Sorry, I don't think I'll get to this by my EOD and I'm out of the rest of the week, so I'll unrequest myself. The version #s and right way to align this with changes to Onda still isn't totally clear to me. E.g. Onda is not compatible with v0.3 of TimeSpans.jl which is a complication here.

@ericphanson
ericphanson removed their request for review July 12, 2022 17:04
haberdashPI and others added 2 commits July 12, 2022 16:32
Co-authored-by: Alex Arslan <ararslan@comcast.net>
@haberdashPI

haberdashPI commented Jul 12, 2022

Copy link
Copy Markdown
Member Author

Onda is not compatible with v0.3 of TimeSpans.jl which is a complication here

In some ways I think that makes the process a little easier: if we mark this release as breaking then Onda can release a breaking version that requires 0.4 of TimeSpans (skipping 0.3 altogether).

What work is involved in making Onda compatible with newer versions of TimeSpans?

@ericphanson

Copy link
Copy Markdown
Member

@haberdashPI

Copy link
Copy Markdown
Member Author

Alternatively, if Onda is not compatible with 0.3 at all, we can just mark this as non-breaking (since the only reason it is technically "breaking" for Onda is that it was pirating some methods that belonged here).

Whenever Onda gets upgraded to support TimeSpans 0.3, it will have to also remove the methods it pirates.

@haberdashPI

haberdashPI commented Jul 12, 2022

Copy link
Copy Markdown
Member Author

beacon-biosignals/Onda.jl#123

Thanks that's helpful background! Looks like there are a number of moving parts to supporting TimeSpans 0.3 unrelated to the pirated methods. (Annoyingly that probably needs to be fixed for us to benefit from TimeSpans, since Onda is probably a common dependency).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

More generic NamedTuple handling

4 participants