Enable TPS65217 PMIC shutdown controller for BeagleBone Blue#104
Enable TPS65217 PMIC shutdown controller for BeagleBone Blue#104immortal71 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request adds numerous device tree overlays and supporting files for BeagleBone variants and expansion capes, along with updates to build/maintenance scripts. The changes appear to be newly added files rather than modifications to existing functionality, supporting various hardware configurations including HDMI, LCD displays, I2C devices, SPI, UART, CAN bus, and other peripherals.
Reviewed changes
Copilot reviewed 106 out of 318 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| am335x-bone-common-univ.dtsi | Adds universal pinmux definitions for P8/P9 headers and device configurations |
| am335x-bbb-bone-buses.dtsi | Defines bone bus abstractions for I2C, UART, CAN with pinmux configurations |
| PB-MIKROBUS-*.dtso | Mikrobus socket overlays for PocketBeagle (slots 0 and 1) |
| M-BB-BBG*.dtso | Model identification overlays for BeagleBone Green variants |
| BB-HDMI-*.dtso | HDMI cape overlays supporting TDA998x, IT66121, and IT66122 chips |
| BB-LCD-*.dtso | LCD display overlays for various screen sizes and controllers |
| BB-I2C*.dtso | I2C device overlays (RTC, sensors, speed configurations) |
| BB-UART*.dtso | UART interface overlays for serial communication |
| BB-SPI*.dtso | SPI device overlays for SPI bus configurations |
| BB-CAN*.dtso | CAN bus overlays for CAN0 and CAN1 interfaces |
| BB-BONE-*.dtso | Cape overlays for eMMC, LCD displays, and other expansions |
| BB-W1-*.dtso | 1-wire interface overlay |
| BONE-LED-*.dtso | GPIO LED configuration overlays |
| BONE-ADC.dtso | ADC enable overlay using bone bus abstraction |
| BBORG_*.dtso | BeagleBone.org accessory overlays (relay, fan, comms) |
| DLPDLCR2000-*.dtso | DLP projector cape overlay |
| BB-EHRPWM*.dtso | Enhanced PWM overlays for motor control |
| BB-CAPE-DISP-*.dtso | Display cape overlays |
| scripts/* | Build and maintenance script updates with filter improvements |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Enable ti,pmic-shutdown-controller property for BeagleBone Blue to allow proper system shutdown. Without this property, the board does not shut down completely - 3V3 rail stays powered and the power LED remains on, requiring a manual reset button press to fully power off. The property was previously deleted, but this causes incomplete shutdown as reported in issue beagleboard#68. The TPS65217 PMIC needs the shutdown-controller property to properly sequence power-off and cut power to all rails. With this change, the shutdown sequence works correctly: - All USR LEDs turn off - Power LED turns off - 3V3 rail is powered down - Board fully powers off without requiring reset button This aligns BBBlue behavior with other BeagleBone variants that use ti,pmic-shutdown-controller for proper power management. Fixes: beagleboard#68 Signed-off-by: immortal71 <newaashish190@gmail.com>
immortal71
force-pushed
the
fix-bbblue-pmic-shutdown
branch
from
a456d00 to
2da9056
Compare
|
Rebased onto the latest v6.18.x so this PR now contains a single commit that only removes the /delete-property/ ti,pmic-shutdown-controller; line from am335x-boneblue.dts to restore PMIC shutdown on BBBlue. |
|
This change occurred in 2019, need to test on real hardware.. https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/arch/arm/boot/dts/am335x-boneblue.dts?h=v6.1.159&id=a27401cecf7795cda7e0c17751feb98fedbaa99d |
|
@RobertCNelson Thanks for the link and context. |
|
@RobertCNelson hello Can do anything in this pr so do i need to wait more , can you guide me what to here ?? |
|
Tested on real hardware? |
yes !! |
|
@immortal71 then this needs to be submitted mainline.. then it'll get backported.. |
Fixes # ~68
Problem
BeagleBone Blue does not shut down completely when using Debian 12.x with kernel 5.10.x or newer:
This differs from Debian 10.3 behavior where shutdown worked correctly.
Root Cause
The
am335x-boneblue.dtsfile explicitly deletes theti,pmic-shutdown-controllerproperty from the TPS65217 PMIC configuration. This property is required for proper power sequencing during shutdown.Without this property, the PMIC does not receive the shutdown signal to cut power to all voltage rails, leaving the board in a partially powered state.
Solution
Remove the
/delete-property/ ti,pmic-shutdown-controller;line to allow the PMIC shutdown controller to function. The property is defined in the inheritedtps65217.dtsiandam335x-bone-common.dtsifiles, and BBBlue should use it like other BeagleBone variants.Changes
/delete-property/ ti,pmic-shutdown-controller;from&tpsnode inam335x-boneblue.dtsExpected Behavior After Fix
Testing Note
I don't have BeagleBone Blue hardware to test this configuration. The fix is based on:
ti,pmic-shutdown-controllersuccessfullyHardware testing by maintainers or community members with BBBlue would be appreciated to confirm the fix resolves the shutdown issue.