/virt/install task fails on networks without DHCP server

[jstodola]

Describe the bug
A /virt/install task executed on a system with static IPv4 configuration and without a DHCP server on the network fails.
I can see that the default network device is not configured with IPv4 after /virt/install is started.

beaker-core-tasks/virt/install/runtest.sh

Line 802 in fb86c70

BOOTPROTO=dhcp

seems to be the problem - Replacing the BOOTPROTO=dhcp line with static IPv4 settings helps (networking is up and running after restarting NetworkManager)

Version-Release number
/virt/install 4.0-101

To Reproduce
Steps to reproduce the behavior:

1. Run the /virt/install task on a host system connected to a network without a DHCP server.

Actual behavior
/virt/install cannot complete, no network connection is available

Expected behavior
/virt/install completes successfully

Additional context
RH J:4739893

[StykMartin]

I'm curious here.
How did you build a machine without a DHCP server?
Did you remove the kickstart part for DHCP and statically defined records? I can't check job (no RH employee)

[jstodola]

Beaker allows to provision systems without DHCP and with the network configuration provided on the kernel command line, see here for example:
https://github.com/beaker-project/beaker/blob/develop/Server/bkr/server/snippets/network
No changes had to be done in the kickstart file from the user point of view - the network kickstart command was omitted in the kickstart file generated by Beaker.

[StykMartin]

Beaker allows to provision systems without DHCP and with the network configuration provided on the kernel command line, see here for example:
https://github.com/beaker-project/beaker/blob/develop/Server/bkr/server/snippets/network
No changes had to be done in the kickstart file from the user point of view - the network kickstart command was omitted in the kickstart file generated by Beaker.

So you basically used the ks_meta I wrote => no_networks.
I understand the problem now. Make sense.