Skip to content
This repository was archived by the owner on Jun 3, 2020. It is now read-only.

Commit 76a9f1d

Browse files
committed
Temporary workaround for missing .version on createDiffStream
1 parent a3fa637 commit 76a9f1d

1 file changed

Lines changed: 10 additions & 8 deletions

File tree

crawler/util.js

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,13 @@ exports.doCrawl = async function (archive, crawlSource, crawlDataset, crawlDatas
6969
})
7070
}
7171

72+
// TEMPORARY
73+
// createDiffStream() doesnt include a .version
74+
// we need an accurate version to checkpoint progress
75+
// for now, use the earliest version
76+
// -prf
77+
changes.forEach(c => { c.version = version })
78+
7279
crawlerEvents.emit('crawl-dataset-start', {sourceUrl: archive.url, crawlDataset, crawlRange: {start, end}})
7380

7481
// handle changes
@@ -115,14 +122,9 @@ exports.emitProgressEvent = function (sourceUrl, crawlDataset, progress, numUpda
115122
* @returns {Array<Object>}
116123
*/
117124
exports.getMatchingChangesInOrder = function (changes, regex) {
118-
var list = [] // order matters, must be oldest to newest
119-
changes.forEach(c => {
120-
if (regex.test(c.name)) {
121-
let i = list.findIndex(c2 => c2.name === c.name)
122-
if (i !== -1) list.splice(i, 1) // remove from old position
123-
list.push(c)
124-
}
125-
})
125+
var list = []
126+
list = changes.filter(c => regex.test(c.name))
127+
list.sort((a, b) => a.version - b.version) // order matters, must be oldest to newest
126128
return list
127129
}
128130

0 commit comments

Comments
 (0)