Skip to content

Teams#196

Open
cooper-grc wants to merge 6 commits into
mainfrom
cg/teams-3
Open

Teams#196
cooper-grc wants to merge 6 commits into
mainfrom
cg/teams-3

Conversation

@cooper-grc
Copy link
Copy Markdown
Contributor

@cooper-grc cooper-grc commented Apr 9, 2026

Summary by cubic

Add Microsoft Teams as a first-class source and tool. You can search Teams messages via smart queries and post messages to channels.

Written for commit 5004a45. Summary will update on new commits.

Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6 issues found across 22 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="pkg/tools/clients/teams.go">

<violation number="1" location="pkg/tools/clients/teams.go:86">
P2: `resolveIDs` only searches the first page of Graph results and ignores `@odata.nextLink`, so lookups can fail for users with many teams/channels.</violation>
</file>

<file name="pkg/sources/providers/teams.go">

<violation number="1" location="pkg/sources/providers/teams.go:292">
P1: `ReadResult` passes message/reply IDs to `fetchReply` in the wrong order, so reply reads call the wrong Graph endpoint.</violation>

<violation number="2" location="pkg/sources/providers/teams.go:349">
P1: Result IDs are serialized with `:` delimiters without escaping, so parsing is ambiguous when any component contains `:`.</violation>

<violation number="3" location="pkg/sources/providers/teams.go:695">
P2: Channel-query parsing splits on whitespace, so `in:Team Name/Channel Name` cannot be parsed and incorrectly falls back to broad search.</violation>
</file>

<file name="pkg/sources/queries/baml_client/functions.go">

<violation number="1" location="pkg/sources/queries/baml_client/functions.go:728">
P1: Do not panic on encode failure; return the error so callers can handle it.</violation>
</file>

<file name="pkg/gateway/services/view_filters.go">

<violation number="1" location="pkg/gateway/services/view_filters.go:316">
P2: Team/channel values are injected into `in:` without escaping, so names containing spaces break Teams channel-query parsing and silently degrade to broader search.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.

Comment thread pkg/sources/providers/teams.go Outdated
Comment thread pkg/sources/providers/teams.go
Comment thread pkg/sources/queries/baml_client/functions.go
Comment thread pkg/tools/clients/teams.go Outdated
Comment thread pkg/sources/providers/teams.go Outdated
Comment thread pkg/gateway/services/view_filters.go Outdated
@cooper-grc cooper-grc requested a review from luke-lombardi April 9, 2026 23:36
Base automatically changed from cg/outlook-mailbox to main April 17, 2026 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant