Teams#196
Open
cooper-grc wants to merge 6 commits into
Open
Conversation
There was a problem hiding this comment.
6 issues found across 22 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="pkg/tools/clients/teams.go">
<violation number="1" location="pkg/tools/clients/teams.go:86">
P2: `resolveIDs` only searches the first page of Graph results and ignores `@odata.nextLink`, so lookups can fail for users with many teams/channels.</violation>
</file>
<file name="pkg/sources/providers/teams.go">
<violation number="1" location="pkg/sources/providers/teams.go:292">
P1: `ReadResult` passes message/reply IDs to `fetchReply` in the wrong order, so reply reads call the wrong Graph endpoint.</violation>
<violation number="2" location="pkg/sources/providers/teams.go:349">
P1: Result IDs are serialized with `:` delimiters without escaping, so parsing is ambiguous when any component contains `:`.</violation>
<violation number="3" location="pkg/sources/providers/teams.go:695">
P2: Channel-query parsing splits on whitespace, so `in:Team Name/Channel Name` cannot be parsed and incorrectly falls back to broad search.</violation>
</file>
<file name="pkg/sources/queries/baml_client/functions.go">
<violation number="1" location="pkg/sources/queries/baml_client/functions.go:728">
P1: Do not panic on encode failure; return the error so callers can handle it.</violation>
</file>
<file name="pkg/gateway/services/view_filters.go">
<violation number="1" location="pkg/gateway/services/view_filters.go:316">
P2: Team/channel values are injected into `in:` without escaping, so names containing spaces break Teams channel-query parsing and silently degrade to broader search.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Add Microsoft Teams as a first-class source and tool. You can search Teams messages via smart queries and post messages to channels.
New Features
Teamssource and tool client in the gateway.InferTeamsQuerywith filename templating and limits.team,channel,from,after,before.{date}_{team}_{channel}_{user}_{id}.txt.teamstool withpost-message(team, channel, text).prompt=consent, clearer user-facing errors for admin consent and other failures.Migration
Written for commit 5004a45. Summary will update on new commits.