Skip to content

Fix fastloop initialization and add regression test#16

Merged
luke-lombardi merged 2 commits into
mainfrom
cursor/fix-fastloop-initialization-and-add-regression-test-claude-4.5-opus-high-thinking-e7fb
Nov 26, 2025
Merged

Fix fastloop initialization and add regression test#16
luke-lombardi merged 2 commits into
mainfrom
cursor/fix-fastloop-initialization-and-add-regression-test-claude-4.5-opus-high-thinking-e7fb

Conversation

@luke-lombardi
Copy link
Copy Markdown
Contributor

Fixes infer_application_path to correctly determine the user's application module, preventing Hypercorn NoAppError.

Commit 38148e9 introduced a bug where infer_application_path would incorrectly fall back to app_instance (the FastLoop instance itself) if no app attribute was found. This caused app_instance.__module__ to return "fastloop.fastloop", leading Hypercorn to search for fastloop.fastloop:app, which does not exist, resulting in a NoAppError. The fix ensures that if no app attribute is present, the function correctly proceeds to argv-based inference to find the user's module. Regression tests have been added to prevent future regressions.


Open in Cursor Open in Web

Co-authored-by: luke <luke@smartshare.io>
@cursor
Copy link
Copy Markdown

cursor Bot commented Nov 26, 2025

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

Co-authored-by: luke <luke@smartshare.io>
@luke-lombardi luke-lombardi merged commit 2063b69 into main Nov 26, 2025
2 checks passed
@luke-lombardi luke-lombardi deleted the cursor/fix-fastloop-initialization-and-add-regression-test-claude-4.5-opus-high-thinking-e7fb branch November 26, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants