Windows Compatibility: Simplify ETag generation by modifying path sanitization to replace only forward slashes.

koriym · koriym · commit 063292dc6726 · 2025-06-19T06:13:27.000+09:00
diff --git a/src/DevEtagSetter.php b/src/DevEtagSetter.php
@@ -28,7 +28,7 @@ public function __construct(
      */
     public function __invoke(ResourceObject $ro, int|null $time = null, HttpCache|null $httpCache = null)
     {
-        $ro->headers[Header::ETAG] =  sprintf('%s_%s', str_replace([':', DIRECTORY_SEPARATOR], ['_', '_'], $ro->uri->path), http_build_query($ro->uri->query));
+        $ro->headers[Header::ETAG] =  sprintf('%s_%s', str_replace('/', '_', $ro->uri->path), http_build_query($ro->uri->query));
         $ro->headers[Header::LAST_MODIFIED] = gmdate(DateTimeInterface::RFC7231, 0);
         $this->setCacheDependency($ro);
     }

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ public function __construct(`
`28`	`28`	`*/`
`29`	`29`	`public function __invoke(ResourceObject $ro, int\|null $time = null, HttpCache\|null $httpCache = null)`
`30`	`30`	`{`
`31`		`- $ro->headers[Header::ETAG] = sprintf('%s_%s', str_replace([':', DIRECTORY_SEPARATOR], ['_', '_'], $ro->uri->path), http_build_query($ro->uri->query));`
	`31`	`+ $ro->headers[Header::ETAG] = sprintf('%s_%s', str_replace('/', '_', $ro->uri->path), http_build_query($ro->uri->query));`
`32`	`32`	`$ro->headers[Header::LAST_MODIFIED] = gmdate(DateTimeInterface::RFC7231, 0);`
`33`	`33`	`$this->setCacheDependency($ro);`
`34`	`34`	`}`