Simplify str_replace in UriTag::buildKey by removing unnecessary directory separator replacement

koriym · koriym · commit 504bad0c8793 · 2025-06-18T16:28:34.000+09:00
diff --git a/src/UriTag.php b/src/UriTag.php
@@ -26,7 +26,7 @@ public function __invoke(AbstractUri $uri): string
         $query = $uri->query;
         ksort($query);
 
-        return str_replace([DIRECTORY_SEPARATOR, '/'], '_', sprintf('%s_%s', $uri->path, http_build_query($query)));
+        return str_replace('/', '_', sprintf('%s_%s', $uri->path, http_build_query($query)));
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ public function __invoke(AbstractUri $uri): string`
`26`	`26`	`$query = $uri->query;`
`27`	`27`	`ksort($query);`
`28`	`28`
`29`		`- return str_replace([DIRECTORY_SEPARATOR, '/'], '_', sprintf('%s_%s', $uri->path, http_build_query($query)));`
	`29`	`+ return str_replace('/', '_', sprintf('%s_%s', $uri->path, http_build_query($query)));`
`30`	`30`	`}`
`31`	`31`
`32`	`32`	`/**`