Satisfy PHPMD and cover Safe logger edge paths

CI surfaced two checks the unpushed branch had never run locally:

- sa/PHPMD flagged UnusedFormalParameter on no-op / contract-driven signatures.
  Add @SuppressWarnings("PHPMD.UnusedFormalParameter") (quoted so PHPStan's
  phpDoc parser accepts the dotted rule name) on NullSemanticLogger and on
  SafeSemanticLogger::__unserialize, whose parameters are required by the
  interface / magic-method contract but intentionally unused.
- codecov (100% target) flagged the no-op NullSemanticLogger methods and the
  best-effort catch blocks in SafeSemanticLogger::event()/close() as uncovered.
  NullSemanticLogger is a pure no-op null object, so its methods are marked
  @codeCoverageIgnore; the SafeSemanticLogger catch blocks are the resilience
  guarantee, so they get real failure tests instead.

Also address review nitpicks: merge the two stacked docblocks on
StructuredRepositoryLoggerInterface, and unlink the temp file in
SemanticLogTreeTrait.

Author: koriym

src/Log/NullSemanticLogger.php

@@ -15,28 +15,42 @@
  * Zero-cost default when cache logging is turned off. open() returns an empty
  * id (which SafeSemanticLogger and disciplined call sites treat as "no close
  * needed"), and flush() returns an empty log session.
+ *
+ * Every parameter is dictated by SemanticLoggerInterface and intentionally
+ * unused in this no-op implementation. The methods are trivial no-ops with no
+ * behavior to assert, so each is excluded from coverage rather than carrying
+ * tests that prove nothing.
+ *
+ * @SuppressWarnings("PHPMD.UnusedFormalParameter")
  */
 final class NullSemanticLogger implements SemanticLoggerInterface
 {
     private const EMPTY_SCHEMA_URL = 'https://koriym.github.io/Koriym.SemanticLogger/schemas/semantic-log.json';
 
+    /** @codeCoverageIgnore */
     #[Override]
     public function open(AbstractContext $context): string
     {
         return '';
     }
 
+    /** @codeCoverageIgnore */
     #[Override]
     public function event(AbstractContext $context): void
     {
     }
 
+    /** @codeCoverageIgnore */
     #[Override]
     public function close(AbstractContext $context, string $openId): void
     {
     }
 
-    /** {@inheritDoc} */
+    /**
+     * {@inheritDoc}
+     *
+     * @codeCoverageIgnore
+     */
     #[Override]
     public function flush(array $links = []): LogJson
     {

src/Log/SafeSemanticLogger.php

@@ -130,7 +130,13 @@ public function __serialize(): array
         return [];
     }
 
-    /** @param array<string, mixed> $data */
+    /**
+     * Session state is never carried across serialization, so the payload is ignored.
+     *
+     * @param array<string, mixed> $data
+     *
+     * @SuppressWarnings("PHPMD.UnusedFormalParameter")
+     */
     public function __unserialize(array $data): void
     {
         $this->logger = new SemanticLogger();

src/StructuredRepositoryLoggerInterface.php

@@ -10,8 +10,7 @@
  * Separated from RepositoryLoggerInterface so that adding structured accessors
  * does not break third-party RepositoryLoggerInterface implementations (BC).
  * Use this for structural assertions instead of substring-matching __toString().
- */
-/**
+ *
  * @deprecated Since the SemanticLogger migration; structured logs are now the
  *   {@see \Koriym\SemanticLogger\LogJson} tree returned by SemanticLogger::flush().
  */

tests/SafeSemanticLoggerTest.php

@@ -68,4 +68,66 @@ public function testSerializesWithoutCarryingSessionState(): void
         $restored->close(new CacheMissContext('resource'), $id);
         $this->assertCount(1, $restored->flush()->toArray()['open']);
     }
+
+    public function testEventFailureIsSwallowed(): void
+    {
+        // Delegate succeeds on open() (so SafeSemanticLogger stays unbroken and enters
+        // event()'s try) but throws on event(): the failure must be swallowed.
+        $flaky = new class implements SemanticLoggerInterface {
+            public function open(AbstractContext $context): string
+            {
+                return 'x';
+            }
+
+            public function event(AbstractContext $context): void
+            {
+                throw new RuntimeException('event failed');
+            }
+
+            public function close(AbstractContext $context, string $openId): void
+            {
+            }
+
+            public function flush(array $links = []): LogJson
+            {
+                return new LogJson('https://koriym.github.io/Koriym.SemanticLogger/schemas/semantic-log.json', [], [], [], $links);
+            }
+        };
+        $safe = new SafeSemanticLogger($flaky);
+
+        $safe->open(new GetContext('page://self/x'));
+        $safe->event(new CacheMissContext('resource')); // throws inside; must not escape
+        // The session is marked broken and flush() returns an empty log without throwing.
+        $this->assertSame([], $safe->flush()->toArray()['open']);
+    }
+
+    public function testCloseFailureIsSwallowed(): void
+    {
+        // Delegate succeeds on open() but throws on close(): the failure must be swallowed.
+        $flaky = new class implements SemanticLoggerInterface {
+            public function open(AbstractContext $context): string
+            {
+                return 'x';
+            }
+
+            public function event(AbstractContext $context): void
+            {
+            }
+
+            public function close(AbstractContext $context, string $openId): void
+            {
+                throw new RuntimeException('close failed');
+            }
+
+            public function flush(array $links = []): LogJson
+            {
+                return new LogJson('https://koriym.github.io/Koriym.SemanticLogger/schemas/semantic-log.json', [], [], [], $links);
+            }
+        };
+        $safe = new SafeSemanticLogger($flaky);
+
+        $id = $safe->open(new GetContext('page://self/x'));
+        $safe->close(new CacheMissContext('resource'), $id); // throws inside; must not escape
+        $this->assertSame([], $safe->flush()->toArray()['open']);
+    }
 }

tests/SemanticLogTreeTrait.php

@@ -17,6 +17,7 @@
 use function ob_start;
 use function sys_get_temp_dir;
 use function tempnam;
+use function unlink;
 
 use const JSON_UNESCAPED_SLASHES;
 
@@ -52,6 +53,7 @@ private function flushAndValidate(SemanticLoggerInterface $logger): array
             (new SemanticLogValidator())->validate($file, $schemaDir);
         } finally {
             ob_get_clean();
+            unlink($file);
         }
 
         return $tree;