Simplify surrogate key generation by refactoring str_replace usage in SurrogateKeys constructor

koriym · koriym · commit fbecc37df402 · 2025-06-18T16:53:53.000+09:00
diff --git a/src/SurrogateKeys.php b/src/SurrogateKeys.php
@@ -26,7 +26,8 @@ final class SurrogateKeys
 
     public function __construct(AbstractUri $uri)
     {
-        $uriKey = sprintf('%s_%s', str_replace(DIRECTORY_SEPARATOR, '_', $uri->path), http_build_query($uri->query));
+        $path = str_replace('/', '_', $uri->path);
+        $uriKey = sprintf('%s_%s', $path, http_build_query($uri->query));
         $this->surrogateKeys = [$uriKey];
         $this->uriTag = new UriTag();
     }

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,8 @@ final class SurrogateKeys`
`26`	`26`
`27`	`27`	`public function __construct(AbstractUri $uri)`
`28`	`28`	`{`
`29`		`- $uriKey = sprintf('%s_%s', str_replace(DIRECTORY_SEPARATOR, '_', $uri->path), http_build_query($uri->query));`
	`29`	`+ $path = str_replace('/', '_', $uri->path);`
	`30`	`+ $uriKey = sprintf('%s_%s', $path, http_build_query($uri->query));`
`30`	`31`	`$this->surrogateKeys = [$uriKey];`
`31`	`32`	`$this->uriTag = new UriTag();`
`32`	`33`	`}`