Skip to content

Replace deprecated DateTimeInterface::RFC7231 with literal format string #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
koriym merged 3 commits into from
Feb 7, 2026
Merged

Replace deprecated DateTimeInterface::RFC7231 with literal format string #173

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
516dc92
Replace deprecated DateTimeInterface::RFC7231 with literal format string
koriym Feb 7, 2026
4a310b2
Add Header::RFC7231 constant to avoid hardcoded format string
koriym Feb 7, 2026
0d58311
Use Header::RFC7231 in MobileEtagSetter for consistency
koriym Feb 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/DevEtagSetter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
use BEAR\RepositoryModule\Annotation\HttpCache;
use BEAR\Resource\Request;
use BEAR\Resource\ResourceObject;
use DateTimeInterface;
use Override;

use function gmdate;
Expand All @@ -30,7 +29,7 @@ public function __invoke(ResourceObject $ro, int|null $time = null, HttpCache|nu
// This is useful for debugging purposes.
// Usually, the ETag is a hash of the resource view or body.
$ro->headers[Header::ETAG] = $uriEtag;
$ro->headers[Header::LAST_MODIFIED] = gmdate(DateTimeInterface::RFC7231, 0);
$ro->headers[Header::LAST_MODIFIED] = gmdate(Header::RFC7231, 0);
$this->setCacheDependency($ro);
}

Expand Down
3 changes: 1 addition & 2 deletions src/EtagSetter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
use BEAR\RepositoryModule\Annotation\HttpCache;
use BEAR\Resource\Request;
use BEAR\Resource\ResourceObject;
use DateTimeInterface;
use Override;

use function assert;
Expand Down Expand Up @@ -38,7 +37,7 @@ public function __invoke(ResourceObject $ro, int|null $time = null, HttpCache|nu

$etag = $this->getEtag($ro, $httpCache);
$ro->headers[Header::ETAG] = $etag;
$ro->headers[Header::LAST_MODIFIED] = gmdate(DateTimeInterface::RFC7231, $time);
$ro->headers[Header::LAST_MODIFIED] = gmdate(Header::RFC7231, $time);
$this->setCacheDependency($ro);
}

Expand Down
7 changes: 7 additions & 0 deletions src/Header.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,12 @@ final class Header
public const CACHE_CONTROL = 'Cache-Control';
public const AGE = 'Age';
public const LAST_MODIFIED = 'Last-Modified';

/**
* RFC 7231 date format for HTTP headers
*
* @see https://www.rfc-editor.org/rfc/rfc7231#section-7.1.1.1
*/
public const RFC7231 = 'D, d M Y H:i:s \G\M\T';
public const HTTP_IF_NONE_MATCH = 'HTTP_IF_NONE_MATCH';
}
Loading