Skip to content

chore(deps): bump github.com/hashicorp/consul/api from 1.33.7 to 1.34.2#406

Closed
dependabot[bot] wants to merge 19 commits into
masterfrom
dependabot/go_modules/github.com/hashicorp/consul/api-1.34.2
Closed

chore(deps): bump github.com/hashicorp/consul/api from 1.33.7 to 1.34.2#406
dependabot[bot] wants to merge 19 commits into
masterfrom
dependabot/go_modules/github.com/hashicorp/consul/api-1.34.2

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot Bot commented on behalf of github May 1, 2026 •
edited
Loading

Bumps github.com/hashicorp/consul/api from 1.33.7 to 1.34.2.

Commits

@dependabot dependabot Bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels May 1, 2026
@dependabot dependabot Bot requested a review from mantzas as a code owner May 1, 2026 07:42
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels May 1, 2026
@dependabot dependabot Bot force-pushed the dependabot/go_modules/github.com/hashicorp/consul/api-1.34.2 branch 2 times, most recently from 886fe9c to 99cae81 Compare May 3, 2026 04:50
mantzas
mantzas previously approved these changes May 3, 2026
View reviewed changes
@mantzas mantzas enabled auto-merge (squash) May 3, 2026 16:31
@dependabot
chore(deps): bump github.com/hashicorp/consul/api from 1.33.7 to 1.34.2
ab84d77 
Bumps [github.com/hashicorp/consul/api](https://github.com/hashicorp/consul) from 1.33.7 to 1.34.2.
- [Release notes](https://github.com/hashicorp/consul/releases)
- [Changelog](https://github.com/hashicorp/consul/blob/main/CHANGELOG.md)
- [Commits](hashicorp/consul@api/v1.33.7...api/v1.34.2)

---
updated-dependencies:
- dependency-name: github.com/hashicorp/consul/api
  dependency-version: 1.34.2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot force-pushed the dependabot/go_modules/github.com/hashicorp/consul/api-1.34.2 branch from 99cae81 to ab84d77 Compare May 7, 2026 22:54
@codecov
Copy link
Copy Markdown

codecov Bot commented May 23, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 18.77%. Comparing base (1b34f82) to head (405cb34).

Files with missing lines Patch % Lines
targets/ci/ci.go 0.00% 1 Missing ⚠️
targets/test/test.go 0.00% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mantzas mantzas force-pushed the dependabot/go_modules/github.com/hashicorp/consul/api-1.34.2 branch 5 times, most recently from ef34406 to 5da5977 Compare May 23, 2026 18:41
@mantzas
ci: add -p=1 to CoverArgs to prevent OOM with race detector
dfa7383 
The -coverpkg=./... flag combined with -race instruments all packages in
every test binary, causing excessive memory usage. Serializing test
package execution with -p=1 reduces peak memory to fit within CI runner
limits (Go 1.26 race detector uses more memory than 1.25).
@mantzas mantzas force-pushed the dependabot/go_modules/github.com/hashicorp/consul/api-1.34.2 branch from 5da5977 to dfa7383 Compare May 23, 2026 18:41
mantzas and others added 3 commits May 23, 2026 22:41
@mantzas @claude
test: set GOMEMLIMIT env var for coverage targets to prevent OOM
871ca25 
Adds CoverEnv with GOMEMLIMIT=5500MiB applied when running coverage
targets, using runWithEnv instead of run. Also ignores .antigravitycli/.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@mantzas @claude
test: drop -race from coverage targets to fix OOM on CI runners
6e54886 
The race detector multiplies memory usage significantly. Combined with
-coverpkg=./... and component/integration tests, this consistently
exceeds the GitHub-hosted runner cgroup limit (exit code 137). Coverage
measurement does not require race detection; -race stays in TestArgs for
regular test runs.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@mantzas @claude
test: drop -coverpkg=./... from CoverAll to fix OOM on CI runners
a690d4b 
-coverpkg=./... instruments all 22 packages into every test binary.
Combined with component/integration tests that also spin up Docker
containers, this exceeds the GitHub-hosted runner memory limit (exit
code 137) even with -p=1 and no race detector.

CoverUnit (unit tests only, no Docker) keeps -coverpkg=./... for full
cross-package coverage. CoverAll uses per-package coverage instead,
which keeps each binary's footprint small enough to survive.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
mantzas and others added 7 commits May 23, 2026 23:17
@mantzas @claude
ci: use CoverUnit instead of CoverAll on hosted runners
405cb34 
The component test suite starts Kafka, MongoDB, Redis, Consul, Jaeger,
AWSMock, MockServer, and a test service all at once. Combined these
containers exhaust the 7 GB RAM on GitHub-hosted runners regardless of
Go-level flags (-p=1, no -race, no -coverpkg). Use CoverUnit (unit
tests only) for CI coverage; run CoverAll locally or on a self-hosted
runner with sufficient memory.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@mantzas @claude
docker: add per-container memory limits to fit within CI runner RAM
3786e1c 
The component test suite starts all containers simultaneously: Kafka +
ZooKeeper (2× JVM), MockServer (JVM), MongoDB, Consul, Jaeger, AWSMock,
and Redis. Without limits these collectively exceed the 7 GB available on
GitHub-hosted runners.

Changes:
- Add MemoryMB field to SimpleContainerConfig; wired into HostConfig.Memory
  via the existing hcOpts callback in runContainer
- Kafka: 512 MB cap + KAFKA_HEAP_OPTS=-Xmx256m; ZooKeeper: 256 MB +
  JVMFLAGS=-Xmx128m (keeps JVM within the cgroup limit)
- MockServer: 256 MB + JAVA_OPTS=-Xmx128m; LOG_LEVEL lowered to WARN
- MongoDB: 384 MB + --wiredTigerCacheSizeGB 0.25
- Consul: 128 MB, Jaeger: 256 MB, AWSMock: 256 MB, Redis: 64 MB

Total containers: ~2.1 GB, leaving ~5 GB for Docker daemon, Go binary
and OS. Restore CoverAll in CI now that containers fit within the limit.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@mantzas @claude
style: gofmt kafka component
0afb978 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@mantzas @claude
docker: limit component startup concurrency and tighten JVM non-heap
0aeff4f 
Two changes to reduce peak memory during component tests on CI runners:

1. StartComponents now uses SetLimit(3) so at most 3 components start
   simultaneously. Previously all 8 containers (including 3 JVMs) pulled
   images and initialized concurrently, causing a large memory spike.

2. JVM non-heap flags added to Kafka, ZooKeeper, and MockServer. -Xmx
   only limits the managed heap; Metaspace, CodeCache, and DirectMemory
   are unbounded without explicit caps. New flags:
   - Kafka:      -XX:MaxMetaspaceSize=96m  -XX:ReservedCodeCacheSize=32m  -XX:MaxDirectMemorySize=64m
   - ZooKeeper:  -XX:MaxMetaspaceSize=48m  -XX:ReservedCodeCacheSize=16m  -XX:MaxDirectMemorySize=32m
   - MockServer: -XX:MaxMetaspaceSize=64m  -XX:ReservedCodeCacheSize=32m  -XX:MaxDirectMemorySize=32m

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@mantzas @claude
kafka: replace wurstmeister Kafka+ZooKeeper with Redpanda
0cd3efe 
Two JVM processes (Kafka + ZooKeeper) were the dominant memory consumers
on CI runners. Even with aggressive heap flags (-Xmx256m/-Xmx128m) the
JVM non-heap (Metaspace, CodeCache, DirectMemory, native threads) added
another ~800 MB that Docker cgroup limits were not enforcing reliably.

Redpanda (redpandadata/redpanda) is a Kafka-compatible broker written in
C++. It runs as a single container with no ZooKeeper dependency and uses
~300 MB total, eliminating two JVM processes and roughly 2 GB of peak
memory pressure.

API is preserved: WithTopics("name:partitions:replication") still works.
NewComponent now extracts the KAFKA_CREATE_TOPICS env var (which Redpanda
does not understand) and creates topics via the sarama admin API in the
ready function instead.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@mantzas @claude
fix(kafka): raise Redpanda memory to 512M to prevent startup crash
648640c 
256M was below Seastar's minimum allocation threshold, causing Redpanda
to abort with "Failed to allocate 64 bytes" before accepting connections.
512M allows Redpanda to start (~224MB actual RSS) and the Docker limit
is raised to 640MB to provide headroom.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@mantzas @claude
fix(ci): eliminate sarama from kafka package and add GOGC=25 to cut c…
94c1a8b 
…ompilation RSS

The kafka component now uses Redpanda's bundled rpk CLI (via InitExecCmd)
for topic creation and the admin HTTP API for the ready check, removing
the sarama import from production code.

Sarama (35k lines) caused ~824MB peak RSS during cold compilation of the
kafka sub-package on CI. Without sarama in kafka/, the cold compilation
drops to ~216MB (GOGC=25) or ~309MB (GOGC=100).

Adding GOGC=25 to CoverAll reduces peak RSS during each compilation pass
by ~25-30%, trading extra GC cycles for lower memory headroom.

Combined effect: peak compilation RSS for the component test binary falls
from ~841MB to ~629MB on this machine; CI headroom should clear the 7GB
runner limit.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@mantzas mantzas closed this May 24, 2026
auto-merge was automatically disabled May 24, 2026 13:12

Pull request was closed

@dependabot @github
Copy link
Copy Markdown
Contributor Author

dependabot Bot commented on behalf of github May 24, 2026

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot Bot deleted the dependabot/go_modules/github.com/hashicorp/consul/api-1.34.2 branch May 24, 2026 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mantzas mantzas mantzas left review comments

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file go Pull requests that update Go code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mantzas