Skip to content

Genbank parser doesn't handle feature attributes with colliding names. #383

@TimothyStiles

Description

@TimothyStiles

Describe the bug

The genbank parser cannot handle repeating attribute keys like with /db_xref below:

Screen Shot 2023-10-06 at 2 01 30 PM

Severity of the bug

This is blocking Ark's ability to cross reference other databases. (priority)

Steps to reproduce

You can debug this by debugging BenchmarkRead(b *testing.B){} in genbank_test.go within a couple of feature extraction loops you'll see that db_xref only keeps the last reference.

Expected behavior

We need to be able to track attributes with the same key name. List of tuples?

Screenshots

Screen Shot 2023-10-06 at 3 39 43 PM

Client information

  • OS: Mac OSX 0.15.7
  • Golang version: 1.21
  • poly version v0.27.1

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinghardA major or complex undertakinghelp wantedExtra attention is neededhigh priorityHigh priority - something is broken or missing that is critical for users or developers.stale

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions