Skip to content

fix: remove unused parent from macro update#1001

Merged
wakonig merged 1 commit into
mainfrom
fix/macro_update
Jul 9, 2026
Merged

fix: remove unused parent from macro update#1001
wakonig merged 1 commit into
mainfrom
fix/macro_update

Conversation

@wakonig

@wakonig wakonig commented Jul 9, 2026

Copy link
Copy Markdown
Member

Description

fixing a bug in the macro update handler introduced by the transition away from static methods

Copilot AI review requested due to automatic review settings July 9, 2026 08:31

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aligns the macro update callback API with how the Redis connector invokes callbacks (single message object, no extra “parent” argument), and updates the corresponding unit tests accordingly.

Changes:

  • Remove the unused parent parameter from MacroUpdateHandler._macro_update_callback.
  • Update test_user_macros.py to call _macro_update_callback(mock_msg) with the new signature.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
bec_lib/bec_lib/macro_update_handler.py Simplifies _macro_update_callback signature to accept only the message object.
bec_lib/tests/test_user_macros.py Updates macro update callback tests to match the new callback signature.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov

codecov Bot commented Jul 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@wakonig wakonig requested a review from cappel89 July 9, 2026 08:50
@wakonig wakonig merged commit 9b932cf into main Jul 9, 2026
58 checks passed
@wakonig wakonig deleted the fix/macro_update branch July 9, 2026 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants