fix: improve error handling for missing device attributes in DeviceCo…#979
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts DeviceContainer.__getattr__ to avoid the confusing super()-related failure on missing “private”/special attribute lookups, improving the error surfaced to users and keeping introspection/IPython completion from being disrupted.
Changes:
- Update
DeviceContainer.__getattr__to raiseAttributeErrorfor missing__*lookups while continuing to raiseDeviceConfigErrorfor missing device names. - Add a regression test ensuring missing single-underscore device lookups raise
DeviceConfigError.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
bec_lib/bec_lib/devicemanager.py |
Changes DeviceContainer.__getattr__ handling for missing __* attributes to raise AttributeError for safer introspection. |
bec_lib/tests/test_devices.py |
Adds a test for missing single-underscore attribute access on DeviceContainer. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cappel89
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a user would mistype and try to access something like
They would get a cryptic error that the super has no attribute "getattr". This PR fixes it by properly raising an AttributeError beforehand but only for dunder attributes. This was introduced in the past to inform the IPython tab completion about missing fields.