refactor(test): rename device monitor test to device preview and upda…#986
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the end-to-end scan tests to validate the device “preview” stream (via Redis endpoints) instead of the older device monitor test assertions, and fixes a misnamed unit_test metadata tag.
Changes:
- Renamed the e2e test from
test_device_monitortotest_device_previewand switched assertions to useMessageEndpoints.device_preview(...)+connector.get_last(...). - Removed prior
device_monitor-based assertions from the renamed test. - Corrected
bec.metadata["unit_test"]intest_async_data.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
cappel89
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
towards removing the old device monitor 1d / 2d endpoints...