Skip to content

Feature/feedback dialog#1059

Merged
wyzula-jan merged 1 commit into
mainfrom
feature/feedback_dialog
Jul 9, 2026
Merged

Feature/feedback dialog#1059
wyzula-jan merged 1 commit into
mainfrom
feature/feedback_dialog

Conversation

@wakonig

@wakonig wakonig commented Feb 21, 2026

Copy link
Copy Markdown
Member

Description

[Provide a brief description of the changes introduced by this pull request.]

Related Issues

[Cite any related issues or feature requests that are addressed or resolved by this pull request. Link the associated issue, for example, with fixes #123 or closes #123.]

Type of Change

  • Change 1
  • Change 2

How to test

  • Run unit tests
  • Open [widget] in designer and play around with the properties

Potential side effects

[Describe any potential side effects or risks of merging this PR.]

Screenshots / GIFs (if applicable)

image

Additional Comments

[Add any additional comments or information that may be helpful for reviewers.]

Definition of Done

  • Documentation is up-to-date.

@wakonig wakonig changed the base branch from main to pre_release_v3 February 21, 2026 13:48
@codecov

codecov Bot commented Feb 21, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.66013% with 25 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...widgets/utility/feedback_dialog/feedback_dialog.py 86.95% 16 Missing and 2 partials ⚠️
...gets/widgets/containers/main_window/main_window.py 53.33% 7 Missing ⚠️

📢 Thoughts on this report? Let us know!

@github-actions

github-actions Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

This PR is stale because it has been open 120 days with no activity.

@github-actions github-actions Bot added the Stale label Jul 4, 2026
@wakonig wakonig force-pushed the feature/feedback_dialog branch from d99d5e1 to b2bf481 Compare July 7, 2026 13:01
@wakonig wakonig changed the base branch from pre_release_v3 to main July 7, 2026 13:01
@wakonig wakonig removed the Stale label Jul 7, 2026
@wakonig wakonig force-pushed the feature/feedback_dialog branch 3 times, most recently from 1a498ac to bb23bba Compare July 7, 2026 15:06
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Benchmark comparison

Threshold: 20% (lower is better).
Result: 0 regression(s), 0 improvement(s) beyond threshold.

No benchmark regression exceeded the configured threshold.

No benchmark improvement exceeded the configured threshold.

All benchmark results
Benchmark Baseline Current Change Status
BEC IPython client with companion app 2.24582 s 2.11887 s -5.65% ok
BEC IPython client without companion app 2.18166 s 2.14676 s -1.60% ok
Import bec_widgets 0.0132869 s 0.0138794 s +4.46% ok
tests/unit_tests/benchmarks/test_dock_area_benchmark.py::test_add_waveform_to_dock_area 0.151121 s 0.156696 s +3.69% ok

@wyzula-jan wyzula-jan marked this pull request as ready for review July 8, 2026 08:55
Copilot AI review requested due to automatic review settings July 8, 2026 08:55
@wyzula-jan wyzula-jan force-pushed the feature/feedback_dialog branch from bb23bba to 6d00ab1 Compare July 8, 2026 08:55
@wyzula-jan wyzula-jan enabled auto-merge (rebase) July 8, 2026 08:55
@wyzula-jan wyzula-jan self-requested a review July 8, 2026 08:55
wyzula-jan
wyzula-jan previously approved these changes Jul 8, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a new user-facing feedback dialog widget (star rating + comment + optional email), adds unit tests for it, and wires the dialog into the main window’s Help menu to submit feedback via the BEC messaging layer.

Changes:

  • Added FeedbackDialog and StarRating widgets with theme-aware coloring and a feedback_submitted signal.
  • Added unit tests covering dialog/widget behavior and signal emission.
  • Added a “Submit Feedback” action to the main window Help menu and sends a FeedbackMessage on submission.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 7 comments.

File Description
bec_widgets/widgets/utility/feedback_dialog/feedback_dialog.py Adds the new feedback dialog + star rating widget implementation.
bec_widgets/widgets/utility/feedback_dialog/__init__.py Introduces the package module for the feedback dialog feature (currently empty).
bec_widgets/widgets/containers/main_window/main_window.py Adds Help menu action to open the dialog and send submitted feedback via messages.FeedbackMessage.
tests/unit_tests/test_feedback_dialog.py Adds unit tests for the new dialog and rating widget.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread bec_widgets/widgets/containers/main_window/main_window.py
Comment thread bec_widgets/widgets/utility/feedback_dialog/feedback_dialog.py
Comment thread bec_widgets/widgets/utility/feedback_dialog/feedback_dialog.py Outdated
Comment thread tests/unit_tests/test_feedback_dialog.py
Comment thread tests/unit_tests/test_feedback_dialog.py
Comment thread tests/unit_tests/test_feedback_dialog.py
Comment thread tests/unit_tests/test_feedback_dialog.py
@wyzula-jan wyzula-jan disabled auto-merge July 8, 2026 10:13
@wakonig wakonig force-pushed the feature/feedback_dialog branch from 6d00ab1 to 69a05d3 Compare July 8, 2026 10:22
@wakonig wakonig enabled auto-merge (rebase) July 8, 2026 14:17
@wakonig wakonig requested a review from wyzula-jan July 8, 2026 14:17
@wakonig wakonig disabled auto-merge July 8, 2026 14:18
@wakonig

wakonig commented Jul 8, 2026

Copy link
Copy Markdown
Member Author

let's merge this one first: bec-project/bec#1000

@wakonig wakonig force-pushed the feature/feedback_dialog branch from 69a05d3 to a324212 Compare July 9, 2026 12:15
@wyzula-jan wyzula-jan merged commit 4d90869 into main Jul 9, 2026
35 of 41 checks passed
@wyzula-jan wyzula-jan deleted the feature/feedback_dialog branch July 9, 2026 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants