Feature/feedback dialog#1059
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
cd29650 to
32c3d77
Compare
|
This PR is stale because it has been open 120 days with no activity. |
d99d5e1 to
b2bf481
Compare
1a498ac to
bb23bba
Compare
Benchmark comparisonThreshold: 20% (lower is better). No benchmark regression exceeded the configured threshold. No benchmark improvement exceeded the configured threshold. All benchmark results
|
bb23bba to
6d00ab1
Compare
There was a problem hiding this comment.
Pull request overview
This PR introduces a new user-facing feedback dialog widget (star rating + comment + optional email), adds unit tests for it, and wires the dialog into the main window’s Help menu to submit feedback via the BEC messaging layer.
Changes:
- Added
FeedbackDialogandStarRatingwidgets with theme-aware coloring and afeedback_submittedsignal. - Added unit tests covering dialog/widget behavior and signal emission.
- Added a “Submit Feedback” action to the main window Help menu and sends a
FeedbackMessageon submission.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
bec_widgets/widgets/utility/feedback_dialog/feedback_dialog.py |
Adds the new feedback dialog + star rating widget implementation. |
bec_widgets/widgets/utility/feedback_dialog/__init__.py |
Introduces the package module for the feedback dialog feature (currently empty). |
bec_widgets/widgets/containers/main_window/main_window.py |
Adds Help menu action to open the dialog and send submitted feedback via messages.FeedbackMessage. |
tests/unit_tests/test_feedback_dialog.py |
Adds unit tests for the new dialog and rating widget. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
6d00ab1 to
69a05d3
Compare
|
let's merge this one first: bec-project/bec#1000 |
69a05d3 to
a324212
Compare
Description
[Provide a brief description of the changes introduced by this pull request.]
Related Issues
[Cite any related issues or feature requests that are addressed or resolved by this pull request. Link the associated issue, for example, with
fixes #123orcloses #123.]Type of Change
How to test
Potential side effects
[Describe any potential side effects or risks of merging this PR.]
Screenshots / GIFs (if applicable)
Additional Comments
[Add any additional comments or information that may be helpful for reviewers.]
Definition of Done