Skip to content

test(e2e): increase rpc test_available_widgets timout back to 100#1184

Merged
wyzula-jan merged 1 commit into
mainfrom
fix/rpc-timout-test
Jun 2, 2026
Merged

test(e2e): increase rpc test_available_widgets timout back to 100#1184
wyzula-jan merged 1 commit into
mainfrom
fix/rpc-timout-test

Conversation

@wyzula-jan

Copy link
Copy Markdown
Contributor

Description

20s seems to ambitious for CI runners...

Copilot AI review requested due to automatic review settings June 2, 2026 12:32
@wyzula-jan wyzula-jan self-assigned this Jun 2, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Increases the pytest timeout for test_available_widgets from 20 seconds to 100 seconds to accommodate slower CI runners.

Changes:

  • Bumps @pytest.mark.timeout from 20 to 100 on the e2e test that exercises creation/removal of all available widgets.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions

github-actions Bot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Benchmark comparison

Threshold: 20% (lower is better).
Result: 0 regression(s), 0 improvement(s) beyond threshold.

No benchmark regression exceeded the configured threshold.

No benchmark improvement exceeded the configured threshold.

All benchmark results
Benchmark Baseline Current Change Status
BEC IPython client with companion app 6.31268 s 6.22143 s -1.45% ok
BEC IPython client without companion app 2.01088 s 2.18 s +8.41% ok
Import bec_widgets 0.0131545 s 0.0139733 s +6.22% ok
tests/unit_tests/benchmarks/test_dock_area_benchmark.py::test_add_waveform_to_dock_area 0.158572 s 0.149876 s -5.48% ok

@codecov

codecov Bot commented Jun 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@wyzula-jan wyzula-jan merged commit af125e2 into main Jun 2, 2026
68 checks passed
@wyzula-jan wyzula-jan deleted the fix/rpc-timout-test branch June 2, 2026 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants