fix(waveform): allow async signals to be used in waveform#1186
Closed
wakonig wants to merge 1 commit into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Waveform plot’s device-curve categorization logic so curves associated with async-capable signals (from the BEC device manager) are treated as async even if they aren’t listed in the scan’s readout_priority.
Changes:
- Query BEC device manager for async-related signal classes and use that to classify curves as async.
- Extend async classification condition to include devices discovered via the device manager.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+2311
to
+2316
| async_signals = self.client.device_manager.get_bec_signals( | ||
| ["AsyncSignal", "AsyncMultiSignal", "DynamicSignal"] | ||
| ) | ||
| async_signal_objs = defaultdict(list) | ||
| for device, _, entry_data in async_signals: | ||
| async_signal_objs[device].append(entry_data.get("obj_name")) |
Comment on lines
3
to
5
| import json | ||
| from collections import defaultdict | ||
| from typing import TYPE_CHECKING, Literal |
Contributor
Benchmark comparisonThreshold: 20% (lower is better). No benchmark regression exceeded the configured threshold. No benchmark improvement exceeded the configured threshold. All benchmark results
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Contributor
|
closed in favor of #1195 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
[Provide a brief description of the changes introduced by this pull request.]
Related Issues
[Cite any related issues or feature requests that are addressed or resolved by this pull request. Link the associated issue, for example, with
fixes #123orcloses #123.]Type of Change
How to test
Potential side effects
[Describe any potential side effects or risks of merging this PR.]
Screenshots / GIFs (if applicable)
[Include any relevant screenshots or GIFs to showcase the changes made.]
Additional Comments
[Add any additional comments or information that may be helpful for reviewers.]
Definition of Done