Skip to content

fix(waveform): allow async signals to be used in waveform #1186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wakonig wants to merge 1 commit into from
Closed

fix(waveform): allow async signals to be used in waveform #1186

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion bec_widgets/widgets/plots/waveform/waveform.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
from __future__ import annotations

import json
from collections import defaultdict
from typing import TYPE_CHECKING, Literal
Comment on lines 3 to 5

import numpy as np
Expand Down Expand Up @@ -2307,13 +2308,19 @@ def _categorise_device_curves(self) -> str:

readout_priority_async = self._ensure_str_list(readout_priority.get("async", []))
readout_priority_sync = self._ensure_str_list(readout_priority.get("monitored", []))
async_signals = self.client.device_manager.get_bec_signals(
["AsyncSignal", "AsyncMultiSignal", "DynamicSignal"]
)
async_signal_objs = defaultdict(list)
for device, _, entry_data in async_signals:
async_signal_objs[device].append(entry_data.get("obj_name"))
Comment on lines +2311 to +2316

# Iterate over all curves
for curve in self.curves:
if curve.config.source != "device":
continue
dev_name = curve.config.signal.device
if dev_name in readout_priority_async:
if dev_name in readout_priority_async or dev_name in async_signal_objs:
self._async_curves.append(curve)
if hasattr(self.scan_item, "live_data"):
self._setup_async_curve(curve)
Expand Down
Loading