fix(curve_tree): update header labels to reflect device and signal co…#1193
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the CurveTree table headers in the waveform curve settings UI to use clearer terminology that matches the underlying device/signal selection widgets.
Changes:
- Renamed CurveTree column headers from “Name”/“Entry” to “Device”/“Signal”.
Comments suppressed due to low confidence (1)
bec_widgets/widgets/plots/waveform/settings/curve_settings/curve_tree.py:559
- The header labels were updated to "Device"/"Signal", but the inline comment below still refers to "entry". Updating it will keep the code comments consistent with the UI terminology.
["Actions", "Device", "Signal", "Scan #", "Color", "Style", "Width", "Symbol"]
)
header = self.tree.header()
for idx in range(self.tree.columnCount()):
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Benchmark comparisonThreshold: 20% (lower is better). No benchmark regression exceeded the configured threshold. No benchmark improvement exceeded the configured threshold. All benchmark results
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
wyzula-jan
approved these changes
Jun 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Rename Name/Entry to Device/Signal for consistency.