Skip to content

fix(curve_tree): update header labels to reflect device and signal co…#1193

Merged
wakonig merged 1 commit into
mainfrom
fix/waveform_settings_label
Jun 13, 2026
Merged

fix(curve_tree): update header labels to reflect device and signal co…#1193
wakonig merged 1 commit into
mainfrom
fix/waveform_settings_label

Conversation

@wakonig

@wakonig wakonig commented Jun 13, 2026

Copy link
Copy Markdown
Member

Description

Rename Name/Entry to Device/Signal for consistency.

@wakonig wakonig self-assigned this Jun 13, 2026
Copilot AI review requested due to automatic review settings June 13, 2026 10:58

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the CurveTree table headers in the waveform curve settings UI to use clearer terminology that matches the underlying device/signal selection widgets.

Changes:

  • Renamed CurveTree column headers from “Name”/“Entry” to “Device”/“Signal”.
Comments suppressed due to low confidence (1)

bec_widgets/widgets/plots/waveform/settings/curve_settings/curve_tree.py:559

  • The header labels were updated to "Device"/"Signal", but the inline comment below still refers to "entry". Updating it will keep the code comments consistent with the UI terminology.
            ["Actions", "Device", "Signal", "Scan #", "Color", "Style", "Width", "Symbol"]
        )

        header = self.tree.header()
        for idx in range(self.tree.columnCount()):

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions

Copy link
Copy Markdown
Contributor

Benchmark comparison

Threshold: 20% (lower is better).
Result: 0 regression(s), 0 improvement(s) beyond threshold.

No benchmark regression exceeded the configured threshold.

No benchmark improvement exceeded the configured threshold.

All benchmark results
Benchmark Baseline Current Change Status
BEC IPython client with companion app 5.92513 s 6.04175 s +1.97% ok
BEC IPython client without companion app 2.04404 s 2.01551 s -1.40% ok
Import bec_widgets 0.0130524 s 0.0135866 s +4.09% ok
tests/unit_tests/benchmarks/test_dock_area_benchmark.py::test_add_waveform_to_dock_area 0.156152 s 0.152798 s -2.15% ok

@codecov

codecov Bot commented Jun 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@wakonig wakonig requested a review from a team June 13, 2026 11:08
@wakonig wakonig merged commit 68903fc into main Jun 13, 2026
69 checks passed
@wakonig wakonig deleted the fix/waveform_settings_label branch June 13, 2026 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants