Skip to content

fix(property-editor): use QLocale territory API #1196

Merged
wyzula-jan merged 1 commit into
mainfrom
fix/propery-12k-errors
Jun 16, 2026
Merged

fix(property-editor): use QLocale territory API #1196
wyzula-jan merged 1 commit into
mainfrom
fix/propery-12k-errors

Conversation

@wyzula-jan

Copy link
Copy Markdown
Contributor

Description

This should remove 12k warnings from unit tests.

Related Issues

Copilot AI review requested due to automatic review settings June 16, 2026 16:34
@wyzula-jan wyzula-jan self-assigned this Jun 16, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the property editor’s locale handling to use Qt6’s territory-based QLocale APIs, addressing CI noise from deprecation warnings (Issue #870).

Changes:

  • Replaces deprecated QLocale.countryToString(...) with QLocale.territoryToString(...).
  • Switches current-locale selection from loc.country() to loc.territory().

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread bec_widgets/utils/property_editor.py
@github-actions

Copy link
Copy Markdown
Contributor

Benchmark comparison

Threshold: 20% (lower is better).
Result: 0 regression(s), 0 improvement(s) beyond threshold.

No benchmark regression exceeded the configured threshold.

No benchmark improvement exceeded the configured threshold.

All benchmark results
Benchmark Baseline Current Change Status
BEC IPython client with companion app 5.92433 s 6.65248 s +12.29% ok
BEC IPython client without companion app 2.05344 s 2.03803 s -0.75% ok
Import bec_widgets 0.0130751 s 0.0131033 s +0.22% ok
tests/unit_tests/benchmarks/test_dock_area_benchmark.py::test_add_waveform_to_dock_area 0.153234 s 0.159179 s +3.88% ok

@codecov

codecov Bot commented Jun 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@wyzula-jan wyzula-jan requested a review from a team June 16, 2026 17:00
@wyzula-jan wyzula-jan merged commit 7c2ea8b into main Jun 16, 2026
68 checks passed
@wyzula-jan wyzula-jan deleted the fix/propery-12k-errors branch June 16, 2026 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: Warnings during CI

3 participants