Fix lack of provided peaks when not necessary - #1
Merged
Conversation
Give an error message if peaks are not provided AND comp_endtidal is True
Author
|
@beccaclements99 if you bring in this PR we can continue with smoia#153 |
Merged
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Necessary for smoia#153
You got the issue right! However the new
compute_petco2hrffunction allows to either run endtidal interpolation or convolution with a response function or both, so it's important not to skip it if pidx are not provided.Instead, this solution should failsafe to a pidx that is "None" when nothing is read and comp_endtidal is required. IN your case, you definitely want to skip the endtidal, but you might want to set your response function to "None" if your file is already convolved.