convert print statements to (debug) logging statements

Author: claytondaley

drf_writable_nested/mixins.py

@@ -550,7 +550,7 @@ def validated_data(self):
     def save(self, **kwargs):
         """Convert validated data into related objects and save."""
         # Create or update direct relations (foreign key, one-to-one)
-        print("RelatedSaveMixin.save for {} with data, kwargs: {}, {}".format(self.__class__.__name__, self._validated_data, kwargs))
+        self.logger.debug("RelatedSaveMixin.save for {} with data, kwargs: {}, {}".format(self.__class__.__name__, self._validated_data, kwargs))
         self._save_direct_relations(kwargs=kwargs)
         instance = super(RelatedSaveMixin, self).save(**kwargs)
         self._save_reverse_relations(instance=instance, kwargs=kwargs)
@@ -563,14 +563,14 @@ def _save_direct_relations(self, kwargs):
         for field_name, field in self.fields.items():
             if self.field_types[field_name] != self.TYPE_DIRECT:
                 continue
-            print("{} direct save {} with data, kwargs;  {}, {}".format(self.__class__.__name__, field_name, self._validated_data.get(field.source, empty), kwargs.get(field_name, {})))
+            self.logger.debug("{} direct save {} with data, kwargs;  {}, {}".format(self.__class__.__name__, field_name, self._validated_data.get(field.source, empty), kwargs.get(field_name, {})))
             if self._validated_data.get(field.source, empty) == empty and kwargs.get(field_name, empty) == empty:
                 continue  # nothing to save
             #if self._validated_data.get(field_name) is None or kwargs.get(field_name) is None:
             #    continue  # delete existing objects
             # we need to pop from kwargs so the value doesn't "overwrite" the value generated by save
             self._validated_data[field.source] = field.save(**kwargs.pop(field_name, {}))
-            print("{}._validated_data[{}] set to direct {}".format(self.__class__.__name__, field_name, self._validated_data[field.source]))
+            self.logger.debug("{}._validated_data[{}] set to direct {}".format(self.__class__.__name__, field_name, self._validated_data[field.source]))
 
     def _format_generic_lookup(self, instance, related_field):
         return {
@@ -588,7 +588,7 @@ def _save_reverse_relations(self, instance, kwargs):
             if self._validated_data.get(field.source, empty) == empty and kwargs.get(field_name, empty) == empty:
                 continue  # nothing to save
             model_field = self._get_model_field(field.source)
-            print("{} populating reverse field {}".format(self.__class__.__name__, model_field.field.name))
+            self.logger.debug("{} populating reverse field {}".format(self.__class__.__name__, model_field.field.name))
             if isinstance(field, serializers.ListSerializer):
                 # reverse FK, inject the instance into reverse relations so the <parent>_id FK field is valid when saved
                 for obj in field._validated_data:
@@ -608,7 +608,7 @@ def _save_reverse_relations(self, instance, kwargs):
                 raise Exception("unexpected serializer type")
             # create/update (as appropriate) related objects
             self._validated_data[field.source] = field.save(**kwargs.get(field_name, {}))
-            print("{}._validated_data[{}] to reverse {}".format(self.__class__.__name__, field_name, self._validated_data[field.source]))
+            self.logger.debug("{}._validated_data[{}] to reverse {}".format(self.__class__.__name__, field_name, self._validated_data[field.source]))
 
             # eliminate related objects that weren't in the request
             if isinstance(field, ListSerializer):
@@ -672,16 +672,16 @@ def build_direct_values(self, kwargs):
         return values
 
     def match(self, kwargs):
-        print("FocalSaveMixin.match with no super and kwargs {}".format(kwargs))
+        self.logger.debug("FocalSaveMixin.match with no super and kwargs {}".format(kwargs))
         return self.instance
 
     @transaction.atomic
     def save(self, **kwargs):
-        print("FocalSaveMixin.save for {} with data, kwargs {}".format(self.__class__.__name__, self._validated_data, kwargs))
+        self.logger.debug("FocalSaveMixin.save for {} with data, kwargs {}".format(self.__class__.__name__, self._validated_data, kwargs))
         if self._validated_data is None and kwargs == {}:
             return None  # deleted
         match = self.match(kwargs)
-        print("Match: {}".format(match))
+        self.logger.debug("Match: {}".format(match))
         self.do_update(match, kwargs)
         try:
             match.save()
@@ -718,7 +718,7 @@ def save(self, **kwargs):
             "need to set extra attributes on the saved model instance. "
             "For example: 'serializer.save(owner=request.user)'.'"
         )
-        print("List-{} save with data, kwargs: {}, {}".format(self.child.__class__.__name__, self._validated_data, kwargs))
+        self.logger.debug("List-{} save with data, kwargs: {}, {}".format(self.child.__class__.__name__, self._validated_data, kwargs))
 
         new_values = []
 
@@ -730,7 +730,7 @@ def save(self, **kwargs):
             if new_value is not None:
                 new_values.append(new_value)
 
-        print("List-{} saved: {}".format(self.child.__class__.__name__, new_values))
+        self.logger.debug("List-{} saved: {}".format(self.child.__class__.__name__, new_values))
         return new_values
 
     def run_validation(self, data=empty):
@@ -827,10 +827,6 @@ def restore_validation_unique(self, unique_validators):
             for validator in validators:
                 fields[name].validators.append(validator)
 
-    def save(self, **kwargs):
-        print("NestedSaveSerializer.save with data, kwargs: {}, {}".format(self._validated_data, kwargs))
-        return super().save(**kwargs)
-
     def update(self, instance, validated_data):
         raise KeyError(
             "Update should never be called on a NestedSerializerBase.  Make sure parent object uses NestedSaveMixin")
@@ -861,7 +857,7 @@ def do_m2m_update(self, match, kwargs):
                     continue  # no information
                 if value is None:
                     value = []  # explicitly clear
-                print("{}:  m2m set to {}, {}".format(self.__class__.__name__, field.source, value))
+                self.logger.debug("{}:  m2m set to {}, {}".format(self.__class__.__name__, field.source, value))
                 getattr(match, field.source).set(value)
 
 
@@ -870,12 +866,12 @@ class GetOnlyNestedSerializerMixin(NestedSaveSerializer):
 
     def match(self, kwargs):
         match = super(GetOnlyNestedSerializerMixin, self).match(kwargs)
-        print("GetOnlyNestedSerializerMixin.match with super {} and kwargs {}".format(match, kwargs))
+        self.logger.debug("GetOnlyNestedSerializerMixin.match with super {} and kwargs {}".format(match, kwargs))
         if match is not None:
             return match
         try:
             match_on = self.build_match_on(kwargs)
-            print("Matching on: {}".format(match_on))
+            self.logger.debug("Matching on: {}".format(match_on))
             return self.queryset.select_for_update().get(**match_on)
         except self.queryset.model.DoesNotExist:
             return None
@@ -890,7 +886,7 @@ class GetOrCreateNestedSerializerMixin(GetOnlyNestedSerializerMixin):
 
     def match(self, kwargs):
         match = super(GetOrCreateNestedSerializerMixin, self).match(kwargs)
-        print("GetOrCreateNestedSerializerMixin.match with super {} and kwargs {}".format(match, kwargs))
+        self.logger.debug("GetOrCreateNestedSerializerMixin.match with super {} and kwargs {}".format(match, kwargs))
         if match is not None:
             return match
         create_values = self.build_direct_values(kwargs)
@@ -905,12 +901,12 @@ class CreateOnlyNestedSerializerMixin(NestedSaveSerializer):
     """Creates requested object or fails."""
 
     def match(self, kwargs):
-        print("GetOrCreateNestedSerializerMixin.match with no super and kwargs {}".format(kwargs))
+        self.logger.debug("GetOrCreateNestedSerializerMixin.match with no super and kwargs {}".format(kwargs))
         create_values = self.build_direct_values(kwargs)
         return self.queryset.model(**create_values)
 
     def do_m2m_update(self, match, m2m_relations):
         # assign relations to forward many-to-many fields
         for k, v in m2m_relations.items():
-            print("{}:  m2m add to {}, {}".format(self.__class__.__name__, k, v))
+            self.logger.debug("{}:  m2m add to {}, {}".format(self.__class__.__name__, k, v))
             getattr(match, k).add(v)