Skip to content

Commit 9e8aaca

Browse files
committed
Fix after review
1 parent 3e38d12 commit 9e8aaca

File tree

7 files changed

+16
-32
lines changed

7 files changed

+16
-32
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -215,8 +215,8 @@ Testing
215215
=======
216216
To run unit tests, run:
217217
```bash
218-
pip install -r requirements/test.txt
219-
pytest
218+
pip install tox
219+
tox -e py37-dj22-drf38
220220
```
221221

222222

requirements.txt

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1,4 @@
1-
-r requirements/base.txt
1+
# PyTest for running the tests.
2+
pytest==5.4.1
3+
pytest-django==3.9.0
4+
pytest-cov==2.8.1

requirements/base.txt

Lines changed: 0 additions & 4 deletions
This file was deleted.

requirements/test.txt

Lines changed: 0 additions & 4 deletions
This file was deleted.

tests/test_writable_nested_model_serializer.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -943,7 +943,6 @@ def test_update_nested_included_in_response(self):
943943
self.assertEqual(user.profile.avatars.count(), 2)
944944

945945
# Add an avatar
946-
url = reverse('user-detail', args=[str(user.pk)])
947946
user_pk = user.pk
948947
profile_pk = user.profile.pk
949948
user_data = {
@@ -965,11 +964,12 @@ def test_update_nested_included_in_response(self):
965964
],
966965
},
967966
}
968-
response = self.client.patch(
969-
url,
970-
user_data,
971-
format='json',
967+
968+
update_serializer = serializers.UserSerializer(
969+
data=user_data,
970+
partial=True
972971
)
973-
self.assertEqual(response.status_code, status.HTTP_200_OK)
974-
self.assertEqual(len(response.data['profile']['avatars']), 3)
972+
update_serializer.is_valid(raise_exception=True)
973+
user = update_serializer.save()
975974
self.assertEqual(user.profile.avatars.count(), 3)
975+

tests/urls.py

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,4 @@
1-
from rest_framework import routers
1+
# This file is only needed to allow for migrations.
2+
# manage.py requires an app to have a urls.py
23

3-
from . import views
4-
5-
router = routers.DefaultRouter()
6-
router.register(r'users', views.UserViewSet)
7-
8-
urlpatterns = router.urls
4+
urlpatterns = []

tests/views.py

Lines changed: 0 additions & 7 deletions
This file was deleted.

0 commit comments

Comments
 (0)