Fix patient document questionnaire canonical link and title lookup#855
Open
mlaletina95 wants to merge 1 commit into
Open
Fix patient document questionnaire canonical link and title lookup#855mlaletina95 wants to merge 1 commit into
mlaletina95 wants to merge 1 commit into
Conversation
Prefer questionnaire.url when saving amended QuestionnaireResponse, and index document list titles by both Questionnaire url and id so legacy responses still resolve the display name. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
formData.context.questionnaire.urlover the previousQuestionnaireResponse.questionnairevalue (which could be a resource id).Questionnairetitles by bothurlandid, so legacy responses still show the correct name instead of Unknown.Context
After amend/save,
QuestionnaireResponse.questionnairecould store the Aidbox resource id (e.g.curated-ips) while the questionnaire canonicalurldiffers (e.g.ips-curated-questionnaire). The documents table looked up titles only by one key, so the name was lost.Test plan
questionnaire= id only → title still resolves if Questionnaire is loaded