fix(context): replace unsafe !! map access with error() guard (kotlin:S6611)

bedaHovorka · claude · bedaHovorka · commit 0b5ab2213658 · 2026-03-27T14:03:35.000+01:00
DefaultSimulationContext.kt line 856 used !! to access a map value after
a containsKey check, which SonarCloud flags as a potential NPE (kotlin:S6611).
Replace with ?: error(...) to provide a clear message if the invariant is
ever violated.

Co-Authored-By: Claude Sonnet 4.6 &lt;noreply@anthropic.com&gt;
diff --git a/core/src/commonMain/kotlin/cz/vutbr/fit/interlockSim/context/DefaultSimulationContext.kt b/core/src/commonMain/kotlin/cz/vutbr/fit/interlockSim/context/DefaultSimulationContext.kt
@@ -853,7 +853,8 @@ open class DefaultSimulationContext(
 
 			// Ensure lookups by DynamicTrackBlock (graph values) still work by aliasing to the same wrapper
 			if (!staticTrackToDynamicMap.containsKey(dynamicBlock)) {
-				staticTrackToDynamicMap[dynamicBlock] = staticTrackToDynamicMap[staticTrack]!!
+				staticTrackToDynamicMap[dynamicBlock] = staticTrackToDynamicMap[staticTrack]
+				?: error("Expected DynamicTrack for $staticTrack to be registered in the map")
 			}
 
 			// Recursively map any internal TrackSection objects

Original file line number	Diff line number	Diff line change
`@@ -853,7 +853,8 @@ open class DefaultSimulationContext(`
`853`	`853`
`854`	`854`	`// Ensure lookups by DynamicTrackBlock (graph values) still work by aliasing to the same wrapper`
`855`	`855`	`if (!staticTrackToDynamicMap.containsKey(dynamicBlock)) {`
`856`		`- staticTrackToDynamicMap[dynamicBlock] = staticTrackToDynamicMap[staticTrack]!!`
	`856`	`+ staticTrackToDynamicMap[dynamicBlock] = staticTrackToDynamicMap[staticTrack]`
	`857`	`+ ?: error("Expected DynamicTrack for $staticTrack to be registered in the map")`
`857`	`858`	`}`
`858`	`859`
`859`	`860`	`// Recursively map any internal TrackSection objects`