Apply reviewer feedback: fix resource leak, enable report types, clear modificationTracker, add setSpeed tests

Agent-Logs-Url: https://github.com/bedaHovorka/interlockSim/sessions/d9498f97-4781-4986-98c1-96cb2a57850d

Co-authored-by: bedaHovorka <5263405+bedaHovorka@users.noreply.github.com>

Author: Copilot

desktop-ui/src/main/kotlin/cz/vutbr/fit/interlockSim/gui/MenuBar.kt

@@ -273,6 +273,20 @@ class MenuBar : JMenuBar() {
 	/**
 	 * Shows a file chooser, loads the selected XML as a [SimulationContext], sets it on the
 	 * [Frame] and immediately starts the simulation.
+	 *
+	 * **Resource management:** The intermediate [EditingContext] created by
+	 * [JvmEditingContextFactory.createContext] is wrapped in `use {}` to ensure its Koin
+	 * scope is closed after the [SimulationContext] transformation, preventing a resource
+	 * leak of the temporary editing context.
+	 *
+	 * **Report types:** All report types are enabled on the [SimulationContext] before
+	 * passing it to [Frame.setContext] so that [AnimationController] and
+	 * [cz.vutbr.fit.interlockSim.gui.animation.EventTimelinePanel] receive property-change
+	 * events and the animation is not visually frozen.
+	 *
+	 * **Modification tracker:** The tracker is cleared before switching to simulation mode
+	 * so that the "unsaved changes" path in [Frame.handleWindowClosing] does not attempt to
+	 * save a [SimulationContext] through the editor's save logic.
 	 */
 	private inner class StartSimulationAction : AbstractAction("Start...") {
 		override fun actionPerformed(e: ActionEvent) {
@@ -285,9 +299,28 @@ class MenuBar : JMenuBar() {
 			val selectedFile: File = fileChooser.selectedFile
 
 			try {
+				val editingContextFactory = getKoin().get<JvmEditingContextFactory>()
 				val simulationContextFactory = getKoin().get<SimulationContextFactory>()
-				val simContext = simulationContextFactory.createContext(selectedFile) as SimulationContext
+
+				// Wrap intermediate EditingContext in use{} to close its Koin scope after
+				// transformation, avoiding a resource leak.
+				val simContext =
+					editingContextFactory.createContext(selectedFile).use { editCtx ->
+						simulationContextFactory.createContext(editCtx as EditingContext)
+					}
+
+				// Enable all report types so AnimationController and EventTimelinePanel receive
+				// property-change events (without this the animation stays visually frozen).
+				simContext.addReportTypes(*SimulationContext.ReportType.values())
+
 				val frame = getKoin().get<Frame>()
+
+				// Clear dirty flag before switching to simulation mode. If the user had unsaved
+				// edits, continuing in simulation mode implicitly discards them; the window-close
+				// handler must not try to save a non-existent EditingContext afterwards.
+				frame.modificationTracker.markClean()
+				frame.modificationTracker.setCurrentFile(null)
+
 				frame.setContext(simContext)
 				frame.startSimulation()
 			} catch (exception: Exception) {

desktop-ui/src/test/kotlin/cz/vutbr/fit/interlockSim/gui/SimulationControllerTest.kt

@@ -443,6 +443,81 @@ class SimulationControllerTest {
 		controller.stop()
 	}
 
+	// ── setSpeed ──────────────────────────────────────────────────────────────
+
+	@Test
+	@Timeout(value = 5, unit = TimeUnit.SECONDS)
+	@DisplayName("setSpeed rejects value below MIN_SPEED")
+	fun setSpeedBelowMinThrows() {
+		val controller = SimulationController(controlPanel)
+		org.junit.jupiter.api.assertThrows<IllegalArgumentException> {
+			controller.setSpeed(SimulationRunner.MIN_SPEED - 0.001)
+		}
+	}
+
+	@Test
+	@Timeout(value = 5, unit = TimeUnit.SECONDS)
+	@DisplayName("setSpeed rejects value above MAX_SPEED")
+	fun setSpeedAboveMaxThrows() {
+		val controller = SimulationController(controlPanel)
+		org.junit.jupiter.api.assertThrows<IllegalArgumentException> {
+			controller.setSpeed(SimulationRunner.MAX_SPEED + 0.001)
+		}
+	}
+
+	@Test
+	@Timeout(value = 5, unit = TimeUnit.SECONDS)
+	@DisplayName("setSpeed accepts boundary values MIN_SPEED and MAX_SPEED")
+	fun setSpeedAcceptsBoundaryValues() {
+		val controller = SimulationController(controlPanel)
+		controller.setSpeed(SimulationRunner.MIN_SPEED)
+		controller.setSpeed(SimulationRunner.MAX_SPEED)
+	}
+
+	@Test
+	@Timeout(value = 10, unit = TimeUnit.SECONDS)
+	@DisplayName("setSpeed applies immediately to an active runner")
+	fun setSpeedAppliedImmediatelyToActiveRunner() {
+		val started = CountDownLatch(1)
+		val blockSim = CountDownLatch(1)
+		every { context.run() } answers {
+			started.countDown()
+			blockSim.await(10, TimeUnit.SECONDS)
+		}
+
+		val controller = SimulationController(controlPanel)
+		controller.start(context)
+		assertThat(started.await(5, TimeUnit.SECONDS)).isTrue()
+
+		controller.setSpeed(2.0)
+		assertThat(controller.runner!!.speedMultiplier).isEqualTo(2.0)
+
+		blockSim.countDown()
+		controller.stop()
+	}
+
+	@Test
+	@Timeout(value = 10, unit = TimeUnit.SECONDS)
+	@DisplayName("setSpeed before start is carried into the next start()")
+	fun setSpeedCarriedIntoNextStart() {
+		val started = CountDownLatch(1)
+		val blockSim = CountDownLatch(1)
+		every { context.run() } answers {
+			started.countDown()
+			blockSim.await(10, TimeUnit.SECONDS)
+		}
+
+		val controller = SimulationController(controlPanel)
+		controller.setSpeed(0.5) // pre-select before start
+		controller.start(context)
+		assertThat(started.await(5, TimeUnit.SECONDS)).isTrue()
+
+		assertThat(controller.runner!!.speedMultiplier).isEqualTo(0.5)
+
+		blockSim.countDown()
+		controller.stop()
+	}
+
 	// ── helpers ───────────────────────────────────────────────────────────────
 
 	private fun findStopButton(): JButton? =