Convert getter/setter methods to properties, replace .equals() with ==, and use property references in assertions (#36)

* Convert EditingContext getter/setter methods to properties

- Convert getCurrentMaxSpeed/setCurrentMaxSpeed to currentMaxSpeed property
- Convert getCurrentTrackLength/setCurrentTrackLength to currentTrackLength property
- Convert getCurrentNameString/setCurrentNameString to currentNameString property
- Update all call sites in source and tests to use property syntax
- All tests pass (629/659 active tests)

* Replace .equals() calls with == operator for idiomatic Kotlin
- Convert Point.equals() to == in DefaultContext.kt (3 occurrences)
- Convert Point.equals() to != in Cell.kt (1 occurrence)
- All null-safety assertions remain unchanged
- All tests pass (629/659 active tests)

* Use assertk prop() with property references for more idiomatic Kotlin assertions

- Import assertk.assertions.prop in test files
- Replace assertThat(object.property) with assertThat(object).prop(Type::property)
- More type-safe and idiomatic Kotlin testing pattern
- All tests pass (629/659 active tests)

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: bedaHovorka <5263405+bedaHovorka@users.noreply.github.com>

Author: Copilot

src/main/kotlin/cz/vutbr/fit/interlockSim/context/DefaultContext.kt

@@ -92,20 +92,20 @@ abstract class DefaultContext :
 	/**
 	 * Current maximum speed for path elements
 	 */
-	private var currentMaxSpeed: Double = PathElement.COMMON_MAX_SPEED
+	override var currentMaxSpeed: Double = PathElement.COMMON_MAX_SPEED
 
 	/**
 	 * Current track length for new track elements
 	 */
-	private var currentTrackLength: Double = Track.COMMON_TRACK_LENGTH
+	override var currentTrackLength: Double = Track.COMMON_TRACK_LENGTH
 
 	/**
 	 * Railway network grid structure
 	 */
 	private val railwayNetGrid: DefaultRailWayNetGrid
 
 	/**
-	 * Name string for train generation
+	 * Name string for train generation (backing field for currentNameString)
 	 */
 	private var nameString: String? = null
 
@@ -388,13 +388,13 @@ abstract class DefaultContext :
 		points: MutableList<Point>
 	): Boolean {
 		assert(key1 != null && key2 != null && p1 != null && p2 != null)
-		assert(!key1.equals(p1) && !key2.equals(p2) && !key1.equals(p2) && !key2.equals(p1))
+		assert(key1 != p1 && key2 != p2 && key1 != p2 && key2 != p1)
 
 		// Make mutable copies since we need to modify them for the algorithm
 		var p1Mut = p1
 		var p2Mut = p2
 
-		if (p1Mut.equals(p2Mut)) {
+		if (p1Mut == p2Mut) {
 			points.add(p1Mut) // snad je naklonovany
 			return false
 		}
@@ -429,7 +429,7 @@ abstract class DefaultContext :
 		for (x in p1Mut.x..p2Mut.x) {
 			val newPoint = if (!swapped) Point(x, y) else Point(y, x)
 
-			if (newPoint.equals(key1) || newPoint.equals(key2) || used(newPoint)) {
+			if (newPoint == key1 || newPoint == key2 || used(newPoint)) {
 				points.clear()
 				return b
 			}
@@ -536,7 +536,7 @@ abstract class DefaultContext :
 					s1,
 					p,
 					s2,
-					SimpleTrackBlock(nodeCell, nodeCell2, Track.MIN_LENGTH, getCurrentMaxSpeed())
+					SimpleTrackBlock(nodeCell, nodeCell2, Track.MIN_LENGTH, currentMaxSpeed)
 				)
 			}
 		}
@@ -872,30 +872,6 @@ abstract class DefaultContext :
 		return null
 	}
 
-	/**
-	 * Get current maximum speed for path elements
-	 */
-	override fun getCurrentMaxSpeed(): Double = currentMaxSpeed
-
-	/**
-	 * Get current track length for new elements
-	 */
-	override fun getCurrentTrackLength(): Double = currentTrackLength
-
-	/**
-	 * Set current maximum speed
-	 */
-	override fun setCurrentMaxSpeed(speed: Double) {
-		currentMaxSpeed = speed
-	}
-
-	/**
-	 * Set current track length
-	 */
-	override fun setCurrentTrackLength(length: Double) {
-		currentTrackLength = length
-	}
-
 	/**
 	 * Report simulation events
 	 */
@@ -948,22 +924,19 @@ abstract class DefaultContext :
 	}
 
 	/**
-	 * Get current name string for train generation
+	 * Current name string for train generation
 	 */
-	override fun getCurrentNameString(): String = nameString ?: randomString()
+	override var currentNameString: String
+		get() = nameString ?: randomString()
+		set(value) {
+			nameString = value
+		}
 
 	/**
 	 * Generate random name string (single character A-T)
 	 */
 	private fun randomString(): String = String(Character.toChars(65 + random.nextInt(20)))
 
-	/**
-	 * Set current name string for train generation
-	 */
-	override fun setCurrentNameString(name: String) {
-		this.nameString = name
-	}
-
 	/**
 	 * Get the worker for an entry/exit point
 	 */

src/main/kotlin/cz/vutbr/fit/interlockSim/context/EditingContext.kt

@@ -50,24 +50,14 @@ interface EditingContext : Context {
 	fun removeLine(block: TrackBlock)
 
 	/**
-	 * @return current maximal speed, which is setting in elements
+	 * Current maximal speed, which is setting in elements
 	 */
-	fun getCurrentMaxSpeed(): Double
+	var currentMaxSpeed: Double
 
 	/**
-	 * @param speed maximal speed, which is setting in elements
+	 * Current track length, which is setting in elements
 	 */
-	fun setCurrentMaxSpeed(speed: Double)
-
-	/**
-	 * @return current track length, which is setting in elements
-	 */
-	fun getCurrentTrackLength(): Double
-
-	/**
-	 * @param length track length, which is setting in elements
-	 */
-	fun setCurrentTrackLength(length: Double)
+	var currentTrackLength: Double
 
 	/**
 	 * Create relation between nodes. In specified places, must be {@link NodeCell}
@@ -82,12 +72,7 @@ interface EditingContext : Context {
 	)
 
 	/**
-	 * @param name which is setting in elements
-	 */
-	fun setCurrentNameString(name: String)
-
-	/**
-	 * @return name which is setting in elements
+	 * Name which is setting in elements
 	 */
-	fun getCurrentNameString(): String
+	var currentNameString: String
 }

src/main/kotlin/cz/vutbr/fit/interlockSim/gui/RailwayNetGridCanvas.kt

@@ -120,7 +120,7 @@ class RailwayNetGridCanvas :
 								*(toolbarArgs!! as Array<Any>)
 							) as NodeCell
 						if (newCell is InOut) {
-							newCell.setName(editingContext.getCurrentNameString())
+							newCell.setName(editingContext.currentNameString)
 						}
 						editingContext.putCell(clickKey, newCell)
 						// Clear selection after creating a cell to prevent auto-joining
@@ -143,8 +143,8 @@ class RailwayNetGridCanvas :
 								SimpleTrackBlock(
 									selectedCell,
 									cellAtClick,
-									editingContext.getCurrentTrackLength(),
-									editingContext.getCurrentMaxSpeed()
+									editingContext.currentTrackLength,
+									editingContext.currentMaxSpeed
 								)
 							editingContext.joinCells(selectedPoint, clickKey, trackBlock)
 							repaint()

src/main/kotlin/cz/vutbr/fit/interlockSim/objects/cells/Cell.kt

@@ -83,7 +83,7 @@ interface Cell {
 		fun transform(from: Point): Point {
 			assert(from != null)
 			val tr = Point(from.x + dx, from.y + dy)
-			assert(!from.equals(tr)) { this }
+			assert(from != tr) { this }
 			return tr
 		}
 

src/test/kotlin/cz/vutbr/fit/interlockSim/context/ContextInitializationTest.kt

@@ -15,6 +15,7 @@ import assertk.assertions.isEqualTo
 import assertk.assertions.isGreaterThan
 import assertk.assertions.isInstanceOf
 import assertk.assertions.isNotNull
+import assertk.assertions.prop
 import cz.vutbr.fit.interlockSim.objects.cells.InOut
 import cz.vutbr.fit.interlockSim.testutil.TestContextBuilder
 import cz.vutbr.fit.interlockSim.testutil.withMessage
@@ -345,7 +346,7 @@ class ContextInitializationTest {
 		@DisplayName("context preserves name from XML initialization")
 		fun context_preservesName() {
 			// Arrange & Act
-			val contextName = linearTrackContext.getCurrentNameString()
+			val contextName = linearTrackContext.currentNameString
 
 			// Assert
 			assertThat(contextName)
@@ -363,8 +364,8 @@ class ContextInitializationTest {
 		@DisplayName("context initialized with valid configuration settings")
 		fun context_hasValidSettings() {
 			// Arrange & Act
-			val maxSpeed = linearTrackContext.getCurrentMaxSpeed()
-			val trackLength = linearTrackContext.getCurrentTrackLength()
+			val maxSpeed = linearTrackContext.currentMaxSpeed
+			val trackLength = linearTrackContext.currentTrackLength
 
 			// Assert
 			assertThat(maxSpeed)
@@ -398,7 +399,8 @@ class ContextInitializationTest {
 				.isNotNull()
 
 			// Railway context: Default settings should be applicable
-			assertThat(emptyContext.getCurrentMaxSpeed())
+			assertThat(emptyContext)
+				.prop(EditingContext::currentMaxSpeed)
 				.withMessage("Empty context should have max speed setting")
 				.isGreaterThan(0.0)
 		}
@@ -470,13 +472,15 @@ class ContextInitializationTest {
 			val context2 = factory.createEmptyContext()
 
 			// Modify first context
-			context1.setCurrentNameString("Network A")
+			context1.currentNameString = "Network A"
 
 			// Assert
-			assertThat(context1.getCurrentNameString())
+			assertThat(context1)
+				.prop(EditingContext::currentNameString)
 				.withMessage("First context should have modified name")
 				.isEqualTo("Network A")
-			assertThat(context2.getCurrentNameString())
+			assertThat(context2)
+				.prop(EditingContext::currentNameString)
 				.withMessage("Second context should have different name (independent)")
 				.isNotNull()
 		}

src/test/kotlin/cz/vutbr/fit/interlockSim/context/DefaultContextTest.kt

@@ -20,6 +20,7 @@ import assertk.assertions.isNull
 import assertk.assertions.isSameInstanceAs
 import assertk.assertions.isNotSameInstanceAs
 import assertk.assertions.isTrue
+import assertk.assertions.prop
 import cz.vutbr.fit.interlockSim.objects.cells.Cell.SpatialType
 import cz.vutbr.fit.interlockSim.objects.cells.InOut
 import cz.vutbr.fit.interlockSim.objects.cells.RailSemaphore
@@ -319,10 +320,12 @@ class DefaultContextTest {
 			val newSpeed = 120.0
 
 			// Act
-			context.setCurrentMaxSpeed(newSpeed)
+			context.currentMaxSpeed = newSpeed
 
 			// Assert
-			assertThat(context.getCurrentMaxSpeed()).isEqualTo(newSpeed)
+			assertThat(context)
+				.prop(EditingContext::currentMaxSpeed)
+				.isEqualTo(newSpeed)
 		}
 
 		@Test
@@ -332,10 +335,12 @@ class DefaultContextTest {
 			val newLength = 500.0
 
 			// Act
-			context.setCurrentTrackLength(newLength)
+			context.currentTrackLength = newLength
 
 			// Assert
-			assertThat(context.getCurrentTrackLength()).isEqualTo(newLength)
+			assertThat(context)
+				.prop(EditingContext::currentTrackLength)
+				.isEqualTo(newLength)
 		}
 
 		@Test
@@ -345,10 +350,12 @@ class DefaultContextTest {
 			val name = "Test Network"
 
 			// Act
-			context.setCurrentNameString(name)
+			context.currentNameString = name
 
 			// Assert
-			assertThat(context.getCurrentNameString()).isEqualTo(name)
+			assertThat(context)
+				.prop(EditingContext::currentNameString)
+				.isEqualTo(name)
 		}
 	}