Apply PR review feedback: fix key bindings, tests, and documentation

- Fix VK_PLUS binding: use Shift+VK_EQUALS for '+' key on standard keyboards, add numpad support
- Remove unreachable catch block in SpeedPresetAction (setSpeed doesn't throw IllegalStateException)
- Remove unused companion object logger in SimulationKeyBindings
- Remove headless test skip - tests use lightweight Swing components that don't need display
- Fix test setup: block context.run() with CountDownLatch to prevent race conditions
- Run all tests and actions on EDT using SwingUtilities.invokeAndWait
- Update MenuBar KDoc to reflect global keyboard shortcuts (remove mention of removed accelerators)
- Remove commented-out accelerator code in MenuBar
- Fix SonarQube workflow condition: include workflow_dispatch to allow manual scans on feature branches

Agent-Logs-Url: https://github.com/bedaHovorka/interlockSim/sessions/86ce4646-5290-410d-98d6-86fe02b0300a

Co-authored-by: bedaHovorka <5263405+bedaHovorka@users.noreply.github.com>

Author: Copilot

.github/workflows/sonarqube.yml

@@ -98,7 +98,7 @@ jobs:
     # Requires SONAR_TOKEN and SONAR_ORGANIZATION secrets configured in GitHub
     # If secrets are not configured, this step will skip gracefully
     - name: SonarCloud Scan
-      if: github.event_name == 'pull_request' || github.ref == 'refs/heads/main' || github.ref == 'refs/heads/develop'
+      if: github.event_name == 'pull_request' || github.event_name == 'workflow_dispatch' || github.ref == 'refs/heads/main' || github.ref == 'refs/heads/develop'
       env:
         GITHUB_ACTOR: ${{ github.actor }}
         SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}

desktop-ui/src/main/kotlin/cz/vutbr/fit/interlockSim/gui/MenuBar.kt

@@ -381,8 +381,9 @@ class MenuBar : JMenuBar() {
 	/**
 	 * Builds the "Simulation" menu with Start/Stop actions and a Speed submenu.
 	 *
-	 * Speed presets (0.1x, 0.5x, 1x, 2x, 10x) have keyboard accelerators (keys 1–5)
-	 * so that the user can change the speed without reaching for the mouse during a run.
+	 * Speed presets (0.1x, 0.5x, 1x, 2x, 10x) are available via menu items.
+	 * Global keyboard shortcuts (keys 1–5, +/-, Space) are handled by [SimulationKeyBindings]
+	 * during simulation mode (Phase 3.1, Issue #193).
 	 */
 	private fun simulationMenu(): JMenu {
 		val menu = JMenu("Simulation")
@@ -399,11 +400,8 @@ class MenuBar : JMenuBar() {
 				Triple("2x", 2.0, KeyEvent.VK_4),
 				Triple("10x", 10.0, KeyEvent.VK_5),
 			)
-		for ((label, multiplier, keyCode) in speedPresets) {
+		for ((label, multiplier, _) in speedPresets) {
 			val item = JMenuItem(SetSpeedAction(label, multiplier))
-			// Note: Keyboard accelerators removed in Phase 3.1 (Issue #193).
-			// Global keyboard shortcuts are now handled by SimulationKeyBindings.
-			// item.accelerator = KeyStroke.getKeyStroke(keyCode, 0)
 			speedMenu.add(item)
 		}
 		menu.add(speedMenu)

desktop-ui/src/main/kotlin/cz/vutbr/fit/interlockSim/gui/SimulationKeyBindings.kt

@@ -70,9 +70,11 @@ internal class SimulationKeyBindings(
 		}
 
 		// Incremental speed adjustment: + increases by ×1.5, - decreases by ÷1.5
-		inputMap.put(KeyStroke.getKeyStroke(KeyEvent.VK_EQUALS, 0), ACTION_KEY_SPEED_UP)
-		inputMap.put(KeyStroke.getKeyStroke(KeyEvent.VK_PLUS, 0), ACTION_KEY_SPEED_UP)
+		// '+' is typically Shift+'=' on most keyboards, so bind both Shift+VK_EQUALS and numpad plus
+		inputMap.put(KeyStroke.getKeyStroke(KeyEvent.VK_EQUALS, KeyEvent.SHIFT_DOWN_MASK), ACTION_KEY_SPEED_UP)
+		inputMap.put(KeyStroke.getKeyStroke(KeyEvent.VK_ADD, 0), ACTION_KEY_SPEED_UP) // Numpad +
 		inputMap.put(KeyStroke.getKeyStroke(KeyEvent.VK_MINUS, 0), ACTION_KEY_SPEED_DOWN)
+		inputMap.put(KeyStroke.getKeyStroke(KeyEvent.VK_SUBTRACT, 0), ACTION_KEY_SPEED_DOWN) // Numpad -
 		actionMap.put(ACTION_KEY_SPEED_UP, IncrementalSpeedAction(multiplier = SPEED_INCREMENT))
 		actionMap.put(ACTION_KEY_SPEED_DOWN, IncrementalSpeedAction(multiplier = 1.0 / SPEED_INCREMENT))
 
@@ -103,9 +105,10 @@ internal class SimulationKeyBindings(
 		}
 
 		// Remove incremental speed bindings
-		inputMap.remove(KeyStroke.getKeyStroke(KeyEvent.VK_EQUALS, 0))
-		inputMap.remove(KeyStroke.getKeyStroke(KeyEvent.VK_PLUS, 0))
+		inputMap.remove(KeyStroke.getKeyStroke(KeyEvent.VK_EQUALS, KeyEvent.SHIFT_DOWN_MASK))
+		inputMap.remove(KeyStroke.getKeyStroke(KeyEvent.VK_ADD, 0))
 		inputMap.remove(KeyStroke.getKeyStroke(KeyEvent.VK_MINUS, 0))
+		inputMap.remove(KeyStroke.getKeyStroke(KeyEvent.VK_SUBTRACT, 0))
 		actionMap.remove(ACTION_KEY_SPEED_UP)
 		actionMap.remove(ACTION_KEY_SPEED_DOWN)
 
@@ -121,7 +124,8 @@ internal class SimulationKeyBindings(
 	/**
 	 * Action that sets the simulation speed to a fixed preset value.
 	 *
-	 * If no simulation is running, the action is a no-op (graceful degradation).
+	 * If no simulation is running, [SimulationController.setSpeed] updates [SimulationController.desiredSpeed]
+	 * which will be applied when the next simulation starts.
 	 */
 	private inner class SpeedPresetAction(private val speed: Double) : AbstractAction() {
 		override fun actionPerformed(e: ActionEvent) {
@@ -130,9 +134,6 @@ internal class SimulationKeyBindings(
 				logger.debug { "Speed preset applied: ${speed}×" }
 			} catch (ex: IllegalArgumentException) {
 				logger.warn { "Invalid speed preset: $speed — ${ex.message}" }
-			} catch (ex: IllegalStateException) {
-				// No runner active — ignore gracefully
-				logger.debug { "Speed preset ignored (no simulation running): $speed" }
 			}
 		}
 	}
@@ -194,8 +195,6 @@ internal class SimulationKeyBindings(
 	}
 
 	companion object {
-		private val logger = KotlinLogging.logger {}
-
 		/** Action key for speed-up shortcut. */
 		private const val ACTION_KEY_SPEED_UP = "simulation_speed_up"