Fix Detekt failures: remove unused imports and migrate to PhysicsConstants (#360)

* Initial plan

* Fix Detekt issues: remove unused imports and update deprecated constants

- Remove unused imports from test files (AnimationIntegrationTest, StatusBarTest, etc.)
- Update deprecated constants to use domain.PhysicsConstants:
  * COMMON_MAX_SPEED in BaseContext.kt
  * MINIMAL_MAX_SPEED in AbstractPath.kt and SimpleTrack.kt
  * MIN_TRACK_LENGTH in SimpleTrack.kt
- All Detekt checks now pass

Co-authored-by: bedaHovorka <5263405+bedaHovorka@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: bedaHovorka <5263405+bedaHovorka@users.noreply.github.com>

Author: Copilot

src/main/kotlin/cz/vutbr/fit/interlockSim/context/BaseContext.kt

@@ -9,10 +9,10 @@
  */
 package cz.vutbr.fit.interlockSim.context
 
+import cz.vutbr.fit.interlockSim.domain.COMMON_MAX_SPEED
 import cz.vutbr.fit.interlockSim.objects.cells.InOut
 import cz.vutbr.fit.interlockSim.objects.core.Cell
 import cz.vutbr.fit.interlockSim.objects.core.Cell.Segment
-import cz.vutbr.fit.interlockSim.objects.core.PathElement
 import cz.vutbr.fit.interlockSim.objects.core.StaticTrack
 import cz.vutbr.fit.interlockSim.objects.tracks.TrackBlock
 import cz.vutbr.fit.interlockSim.util.ExtendedUnorientedGraph
@@ -140,7 +140,7 @@ abstract class BaseContext<T : TrackBlock>(
 	 * Inherited from EditingContext interface.
 	 * Open to allow subclass override if needed.
 	 */
-	open var currentMaxSpeed: Double = cz.vutbr.fit.interlockSim.objects.core.PathElement.COMMON_MAX_SPEED
+	open var currentMaxSpeed: Double = COMMON_MAX_SPEED
 
 	/**
 	 * Current track length for new track elements.

src/main/kotlin/cz/vutbr/fit/interlockSim/objects/paths/AbstractPath.kt

@@ -11,6 +11,7 @@ package cz.vutbr.fit.interlockSim.objects.paths
 
 import cz.vutbr.fit.interlockSim.context.SimulationContext
 import cz.vutbr.fit.interlockSim.context.SimulationContext.ReportType
+import cz.vutbr.fit.interlockSim.domain.MINIMAL_MAX_SPEED
 import cz.vutbr.fit.interlockSim.exceptions.PathSeparatorChangeException
 import cz.vutbr.fit.interlockSim.exceptions.TrackOperationException
 import cz.vutbr.fit.interlockSim.exceptions.requireSimulation
@@ -298,7 +299,7 @@ abstract class AbstractPath protected constructor(
 			}
 		}
 		context.report("", this, ReportType.PATH_SETTING)
-		requireSimulation(maxSpeed(sep) >= PathElement.MINIMAL_MAX_SPEED) {
+		requireSimulation(maxSpeed(sep) >= MINIMAL_MAX_SPEED) {
 			"Max speed must be at least MINIMAL_MAX_SPEED, got: ${maxSpeed(sep)}"
 		}
 	}

src/main/kotlin/cz/vutbr/fit/interlockSim/objects/tracks/SimpleTrack.kt

@@ -10,6 +10,7 @@
 package cz.vutbr.fit.interlockSim.objects.tracks
 
 import cz.vutbr.fit.interlockSim.domain.MINIMAL_MAX_SPEED
+import cz.vutbr.fit.interlockSim.domain.MIN_TRACK_LENGTH
 import cz.vutbr.fit.interlockSim.exceptions.requireSimulation
 import cz.vutbr.fit.interlockSim.objects.core.PathSeparator
 import cz.vutbr.fit.interlockSim.objects.core.StaticTrack
@@ -42,16 +43,13 @@ abstract class SimpleTrack(
 	StaticTrack {
 	companion object {
 		private val logger = KotlinLogging.logger {}
-
-		// Track minimum length constant
-		private const val MIN_LENGTH = StaticTrack.MIN_LENGTH
 	}
 
 	private val speeds: IdentityHashMap<PathSeparator, Double> = IdentityHashMap()
 	private val ends: Array<PathSeparator>
 
 	init {
-		if (length < MIN_LENGTH || maxSpeed1 < MINIMAL_MAX_SPEED || maxSpeed2 < MINIMAL_MAX_SPEED) {
+		if (length < MIN_TRACK_LENGTH || maxSpeed1 < MINIMAL_MAX_SPEED || maxSpeed2 < MINIMAL_MAX_SPEED) {
 			throw IllegalArgumentException("length or maxspeed is very small")
 		}
 		ends = arrayOf(end1, end2)

src/test/kotlin/cz/vutbr/fit/interlockSim/context/BaseContextTest.kt

@@ -11,9 +11,7 @@ package cz.vutbr.fit.interlockSim.context
 
 import assertk.assertThat
 import assertk.assertions.isEqualTo
-import assertk.assertions.isGreaterThan
 import assertk.assertions.isInstanceOf
-import assertk.assertions.isNotNull
 import assertk.assertions.isSameInstanceAs
 import cz.vutbr.fit.interlockSim.objects.cells.InOut
 import cz.vutbr.fit.interlockSim.objects.core.Cell.SpatialType

src/test/kotlin/cz/vutbr/fit/interlockSim/context/SimulationProcessFactoryTest.kt

@@ -11,7 +11,6 @@ package cz.vutbr.fit.interlockSim.context
 
 import assertk.assertThat
 import assertk.assertions.isInstanceOf
-import assertk.assertions.isNotNull
 import cz.vutbr.fit.interlockSim.sim.DefaultSimulationProcessFactory
 import cz.vutbr.fit.interlockSim.sim.Generator
 import cz.vutbr.fit.interlockSim.sim.InOutWorker

src/test/kotlin/cz/vutbr/fit/interlockSim/context/navigation/PathReservationServiceTest.kt

@@ -16,7 +16,6 @@ import assertk.assertions.hasSize
 import assertk.assertions.isEmpty
 import assertk.assertions.isEqualTo
 import assertk.assertions.isFalse
-import assertk.assertions.isGreaterThan
 import assertk.assertions.isGreaterThanOrEqualTo
 import assertk.assertions.isInstanceOf
 import assertk.assertions.isLessThanOrEqualTo

src/test/kotlin/cz/vutbr/fit/interlockSim/di/KoinSingletonConsistencyTest.kt

@@ -10,7 +10,6 @@
 package cz.vutbr.fit.interlockSim.di
 
 import assertk.assertThat
-import assertk.assertions.isNotNull
 import assertk.assertions.isNotSameInstanceAs
 import assertk.assertions.isSameInstanceAs
 import cz.vutbr.fit.interlockSim.context.EditingContextFactory

src/test/kotlin/cz/vutbr/fit/interlockSim/di/NavigationModuleKoinTest.kt

@@ -15,7 +15,6 @@ import assertk.assertThat
 import assertk.assertions.isEmpty
 import assertk.assertions.isEqualTo
 import assertk.assertions.isInstanceOf
-import assertk.assertions.isNotNull
 import assertk.assertions.isNull
 import cz.vutbr.fit.interlockSim.context.navigation.PathReservationService
 import cz.vutbr.fit.interlockSim.context.navigation.TrainNavigationService

src/test/kotlin/cz/vutbr/fit/interlockSim/gui/MenuBarTest.kt

@@ -14,7 +14,6 @@ package cz.vutbr.fit.interlockSim.gui
 import assertk.assertThat
 import assertk.assertions.hasSize
 import assertk.assertions.isEqualTo
-import assertk.assertions.isNotNull
 import org.junit.jupiter.api.BeforeEach
 import org.junit.jupiter.api.DisplayName
 import org.junit.jupiter.api.Test

src/test/kotlin/cz/vutbr/fit/interlockSim/gui/StatusBarTest.kt

@@ -14,7 +14,6 @@ package cz.vutbr.fit.interlockSim.gui
 import assertk.assertThat
 import assertk.assertions.contains
 import assertk.assertions.isEqualTo
-import assertk.assertions.isNotNull
 import cz.vutbr.fit.interlockSim.PROGRAM_NAME
 import cz.vutbr.fit.interlockSim.testutil.KoinTestBase
 import cz.vutbr.fit.interlockSim.testutil.testModuleFull