feat(goal-7): common PR

[Copilot]

Goal 7 requires simulation playback speed control (0.1x–100x) without touching simulation semantics. kDisco runs in pure simulation time with no wall-clock awareness, so speed control is implemented externally via a throttling wrapper.

Tests

All tests from subissues

[bedaHovorka]

The failure is in :desktop-ui:test in the workflow job definition at .github/workflows/gradle-java21.yml, specifically the ./gradlew test step.

The actionable issue from the logs is:

• 1 test failed out of 563
• The failing area is in the desktop-ui test suite
• The logs repeatedly show nearby passing tests such as StatusBar, XMLContextFactoryLenientTest, and ValidationUtils, but the exact failing test name is not present in the retrieved log excerpt
• The HTML test report path mentioned in the logs is local to the runner and wasn’t available from the repository snapshot:
  desktop-ui/build/reports/tests/test/index.html

There are also Kotlin warnings in:

• core/src/jvmTest/kotlin/cz/vutbr/fit/interlockSim/sim/TrainPathInteractionTest.kt
• core/src/jvmTest/kotlin/cz/vutbr/fit/interlockSim/sim/TrainPathInteractionTest.kt

but these are warnings only, not the cause of the job failure.

Solution

Because the failure is in desktop-ui:test and the visible surrounding tests include UI-oriented tests like StatusBar, the most likely fix is to make the failing test deterministic and independent of environment-specific UI timing, locale, or shared state.

What to change

Focus on the failing test under desktop-ui/src/test/... and apply these fixes if it is UI-related:

1. Remove timing/race sensitivity

If the test depends on Swing event dispatch or asynchronous updates, flush the UI queue before asserting:

import javax.swing.SwingUtilities

private fun flushEdt() {
    SwingUtilities.invokeAndWait {}
}

Use it after UI-triggering actions:

statusBar.updateSpeedIndicator(1.5)
flushEdt()
assertEquals("1.5x", speedLabel.text)

2. Avoid locale-dependent assertions

The logs show an existing test for Locale.ROOT, so ensure formatting code uses it consistently:

val text = String.format(Locale.ROOT, "%.1fx", multiplier)

If production code currently uses default locale, replace it with Locale.ROOT.

3. Reset shared singleton/static state between tests

If StatusBar or XML-related tests share listeners, models, or parser state, add cleanup:

@AfterTest
fun tearDown() {
    producer.unregisterAllListeners()
}

or recreate the component fresh in each test:

@BeforeTest
fun setUp() {
    producer = FakeStatusProducer()
    statusBar = StatusBar(producer)
}

4. Replace fragile exact-string assertions

If the test compares rendered messages, prefer semantic assertions:

assertTrue(speedLabel.text.contains("1.5"))

instead of brittle whitespace or platform-specific full-text comparisons.

Strongest likely code fix

If the failing test is in the StatusBar area, the best production-side hardening is:

private fun formatSpeed(multiplier: Double): String =
    String.format(Locale.ROOT, "%.1fx", multiplier)

and in tests:

@Test
fun `updateSpeedIndicator shows speed text when multiplier is not 1_0x`() {
    statusBar.updateSpeedIndicator(1.5)
    flushEdt()

    assertTrue(speedLabel.isVisible)
    assertEquals("1.5x", speedLabel.text)
}

Also clean up the warnings

Those two “condition is always true” warnings in TrainPathInteractionTest.kt should be simplified, for example:

assertNotNull(path)
assertTrue(path.blocks.isNotEmpty())

instead of:

if (path != null) {
    assertTrue(path.blocks.isNotEmpty())
}

or any equivalent always-true guarded pattern.

Summary

The fix is to update the failing desktop-ui test so it is deterministic on CI: flush Swing/EDT work before assertions, force Locale.ROOT for formatted UI text, and isolate shared state per test. The workflow itself is fine; the failure comes from a single flaky or environment-sensitive unit test in the desktop-ui:test step.

[Copilot]

The failure is in :desktop-ui:test in the workflow job definition at [.github/workflows/gradle-java21.yml](https://github.com/bedaHovorka/interlockSim/blob/0beb74dd30190f6ef410451a6fa15078d140ee6e...

Fixed in cf9759b.

The failing test was SimulationControllerSpeedPropagationTest.nullMainProcessNoOp() (confirmed via the uploaded test-results artifact). It timed out because startedLatch.await(5s) blocked until the sim thread called ctx.run(), which took >10s on the busy CI runner.

The fix removes that wait — runner and speedMultiplier are assigned synchronously inside SimulationController.start() before newRunner.start() is called, so the assertions are valid without waiting for the sim thread.

Also cleaned up the always-true train != null conditions in TrainPathInteractionTest.kt (lines 149, 169) as noted in the comment.

[sonarqubecloud]

Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
81.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud