February 2026 Improvements: Bidirectional Trains, Koin Testing, and Code Quality by bedaHovorka · Pull Request #358 · bedaHovorka/interlockSim

bedaHovorka · 2026-02-06T04:22:53Z

February 2026 Improvements: Bidirectional Trains, Koin Testing, and Code Quality

📊 PR Summary

Base Branch: test_cleanup
Commits: 18 commits
Includes: 17 already-merged issues
Test Status: 2,249 tests (2,229 passing, 20 skipped, 0 failing)
Code Coverage: 51%

🚀 Key Features

1. Bidirectional Train Operation

Full support for bidirectional train movement, enabling single-InOut networks.

Includes: #356, #359, #261

Add bidirectional train operation support (Add bidirectional train operation support #356)
Reduce minimum InOut requirement from 2 to 1 (Reduce minimum InOut requirement from 2 to 1 after bidirectional train support #359)
Add lenient XML validation for editor mode (GUI : XML Validation Enhancement - Lenient Opening for Editor Mode #261)

2. Context System Improvements

Enhanced context architecture with better validation and observability.

Includes: #353, #339, #352

Fire PropertyChangeEvents on BaseContext property setters (Fire PropertyChangeEvents on BaseContext property setters #353)
Add comprehensive validation to context transformation (Add comprehensive validation to context transformation #339)
Introduce PathResult sealed class to distinguish permanent vs temporary path unavailability (Introduce PathResult sealed class to distinguish permanent vs temporary path unavailability #352)

3. Koin DI & Performance Testing

Comprehensive scope lifecycle tests and JMH performance benchmarks.

Includes: #346, #345, #343

Implement Koin scope lifecycle tests for scope-per-context pattern (Implement Koin scope lifecycle tests for scope-per-context pattern #346)
Migrate Koin performance test to JMH benchmarks (Migrate Koin performance test to JMH benchmarks #345)
Migrate Array2DMap performance test to JMH benchmarks (Migrate Array2DMap performance test to JMH benchmarks #343)

✅ Code Quality & API Improvements

API Enhancements

Includes: #342, #350

Add Kotlin property accessors to Train public API (Add Kotlin property accessors to Train public API #342)
Remove unused parameters from DefaultTrainNavigationService and AnimationStateCapture (Remove unused parameters from DefaultTrainNavigationService and AnimationStateCapture #350)

Code Quality

Includes: #360, #361

Fix Detekt failures: remove unused imports and migrate to PhysicsConstants (Fix Detekt failures: remove unused imports and migrate to PhysicsConstants #360)
Address PR review feedback: fix indentation, resource leak, test naming (Address PR review feedback: fix indentation, resource leak, test naming #361)

Data Structures & Internal Improvements

Includes: #338, #337, #336, #340

Implement modifiable EntrySet with remove, removeAll, retainAll, and clear operations (Array2DMap: Implement modifiable EntrySet for Map contract compliance #338)
Optimize HashMapGraph collection methods with unmodifiable views (Optimize HashMapGraph collection methods with unmodifiable views #337)
Remove lazy track wrapper creation for consistency with path separator strategy (Remove lazy track wrapper creation for consistency with path separator strategy #336)
Document internal test accessors and add state verification tests (Document internal test accessors and add state verification tests #340)

🐛 Bug Fixes

Fix NavigationModuleKoinTest: correct assertion for InOut path reservation (no issue number)

📋 Complete Issue List

This PR includes the following 17 already-merged issues:

#261, #336, #337, #338, #339, #340, #342, #343, #345, #346, #350, #352, #353, #356, #359, #360, #361

✨ Key Achievements

✅ Zero regressions - All 2,229 tests passing (20 skipped)
✅ Bidirectional train support - Enables more flexible network configurations
✅ Enhanced testing - Koin scope lifecycle tests and JMH performance benchmarks
✅ Improved code quality - Detekt compliance, cleaner APIs, better validation
✅ Better observability - PropertyChangeEvents and PathResult semantics

📝 Review Notes

All commits follow the conservative approach outlined in CLAUDE.md
Test coverage maintained at 51% with 2,249 tests
All issues already merged via individual PRs
Breaking changes: None (backward compatible)

Ready for merge ✅

bedaHovorka · 2026-02-06T06:16:59Z

@copilot in new PR implement please decrease minimal in out in xml from 2 to 1

(thanks this PR #356 , see also #341 - will be merged before this and new PR)

Copilot · 2026-02-06T06:17:06Z

@bedaHovorka I've opened a new pull request, #359, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2026-02-06T08:19:02Z

@bedaHovorka I've opened a new pull request, #360, to work on those changes. Once the pull request is ready, I'll request review from you.

bedaHovorka

@copilot cherry-pick last commit from develop

bedaHovorka · 2026-02-06T09:07:19Z

@copilot cherry-pick last commit from develop

@claude please

bedaHovorka · 2026-02-07T04:43:22Z

@copilot open a new pull request to apply changes based on the comments in this thread

Copilot · 2026-02-07T04:43:29Z

@bedaHovorka I've opened a new pull request, #361, to work on those changes. Once the pull request is ready, I'll request review from you.

…clear operations (#338) Co-authored-by: bedaHovorka <5263405+bedaHovorka@users.noreply.github.com>

* Add PropertyChangeEvent firing to BaseContext property setters - Add custom setters to currentMaxSpeed, currentTrackLength, currentNameString - Fire PropertyChangeEvent when property values change - Add comprehensive unit tests for property change events - Update integration tests to verify event firing - Resolves issue with GUI components not being notified of property changes Co-authored-by: bedaHovorka <5263405+bedaHovorka@users.noreply.github.com> * Fix currentNameString property change event to use getter for old value The currentNameString setter was using the nullable backing field (nameString) for the old value in PropertyChangeEvent, but the getter returns empty string when null. This caused inconsistency between the property's apparent old value and the event's old value. Now using the getter to get a consistent old value. Also updated the test to assert on the old value. * Fix currentNameString setter to avoid polymorphic getter call The setter was calling currentNameString getter to get the old value, but this causes issues with DefaultSimulationContext which overrides the getter with random generation logic. When super.currentNameString is set from the subclass, the BaseContext setter would call the overridden getter, potentially getting a random value instead of the actual old value. Fixed by using backing field directly with same null-handling logic as getter: nameString ?: "" This avoids virtual method calls during property assignment and ensures the old value in PropertyChangeEvent is correct even when called from subclasses. --------- Co-authored-by: bedaHovorka <5263405+bedaHovorka@users.noreply.github.com>

…r strategy (#336) * Initial plan * Implement eager track wrapping for Issue #214 - Update toDynamic(TrackFacility) to throw exception instead of lazy creation - All tracks already wrapped eagerly in initializeDynamicMapping() (lines 736-763) - Add EagerTrackWrappingTest with comprehensive test coverage - Update TrackDynamicMappingTest to reflect eager wrapping behavior - Consistent with path separator wrapping strategy Co-authored-by: bedaHovorka <5263405+bedaHovorka@users.noreply.github.com> * Add comprehensive documentation for Issue #214 - Created ISSUE_214_IMPLEMENTATION_SUMMARY.md with complete analysis - Documents problem statement, solution, and benefits - Lists all file changes and test coverage - Includes validation status and backward compatibility analysis Co-authored-by: bedaHovorka <5263405+bedaHovorka@users.noreply.github.com> * Add visual explanation for Issue #214 - Created ISSUE_214_VISUAL_EXPLANATION.md with diagrams - Shows before/after architecture comparison - Includes timeline comparison and code examples - Explains initialization flow and simulation impact Co-authored-by: bedaHovorka <5263405+bedaHovorka@users.noreply.github.com> * Fix CI build errors in test files (Issue #214) - Replace SimpleTrackBlock.getInstance() with proper constructor - Add RailSemaphore imports and create proper test track objects - Fix type inference in assertThat lambda by adding explicit Unit return - Both issues identified in code review comment #3760719655 Co-authored-by: bedaHovorka <5263405+bedaHovorka@users.noreply.github.com> * Fix assertThat usage in test files - use assertFailure instead - Replace assertThat{}.isFailure() with assertFailure{} pattern - Remove isFailure() import, add assertFailure import - Fixes Kotlin compilation error in EagerTrackWrappingTest.kt line 64 - Also fix TrackDynamicMappingTest.kt for consistency - Addresses code review comment #3761156459 Co-authored-by: bedaHovorka <5263405+bedaHovorka@users.noreply.github.com> * Fix assertFailure message assertion - use message().contains() pattern - Replace messageContains() with message().isNotNull().contains() - Remove messageContains import, add contains import - Fixes receiver type mismatch error in EagerTrackWrappingTest.kt line 69 - Uses correct assertk API pattern matching other tests (InOutValidationTest, TracksPolishTest) - Addresses code review comment #3761547032 Co-authored-by: bedaHovorka <5263405+bedaHovorka@users.noreply.github.com> * Fix assertk message assertion - use transform pattern instead of message() - Replace .message().isNotNull() with .transform { it.message ?: "" } - This is the correct assertk API for accessing exception messages - Matches pattern used in InOutValidationTest - Fixes compilation error: Unresolved reference 'message' - Addresses code review comment #3762776391 Co-authored-by: bedaHovorka <5263405+bedaHovorka@users.noreply.github.com> * Fix contains assertion - cast strings to CharSequence - Cast string literals to CharSequence in contains() calls - This resolves Kotlin compilation error with Assert<String>.contains() - Matches pattern used in TracksPolishTest for string assertions - Fixes compilation error in compileTestKotlin step - Addresses code review comment #3762987304 Co-authored-by: bedaHovorka <5263405+bedaHovorka@users.noreply.github.com> * Fix chained contains calls - use varargs instead - Replace chained .contains() calls with single varargs contains() - Pass multiple CharSequence values to single contains() call - This is the correct assertk API for checking multiple substrings - Matches pattern used in TracksPolishTest - Fixes compilation error at line 70 - Addresses code review comment #3763344015 Co-authored-by: bedaHovorka <5263405+bedaHovorka@users.noreply.github.com> * Fix PathTrackIntegrationTest - initialize dynamic mappings in setUp - Add initializeDynamicMapping() calls in test setUp for both contexts - Required because tests use toDynamic() without calling run() - Issue #214: Tracks now wrapped eagerly, lazy fallback removed - Fixes IllegalStateException: "Map contains 0 entries" - Addresses code review comment #3763464348 Co-authored-by: bedaHovorka <5263405+bedaHovorka@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: bedaHovorka <5263405+bedaHovorka@users.noreply.github.com>

…ry path unavailability (#352) * Update test files to use PathResult sealed class instead of nullable Path - Added PathResult import to all affected test files - Changed assertions from isNotNull() to isInstanceOf(PathResult.Available::class) - Extract path from Available result using: val path = (result as PathResult.Available).path - Changed null assertions to appropriate PathResult variants: - PathResult.OwnershipConflict: when blocks owned by different train or no reservation - PathResult.NoTopologicalPath: when network topology doesn't support path - Updated test comments and descriptions to mention PathResult variants Files updated: - TrainNavigationServiceTest.kt (14 Available, 9 OwnershipConflict, 4 NoTopologicalPath) - TrainPathReservationIntegrationTest.kt (5 Available, 7 OwnershipConflict) - PathDynamicReferencesTest.kt (2 Available) - NavigationModuleKoinTest.kt (2 Available, 1 OwnershipConflict) Total: 23 Available, 17 OwnershipConflict, 4 NoTopologicalPath instances * Implement PathResult sealed class to distinguish permanent vs temporary path unavailability * Fix type mismatch: extract Path from PathResult.Available before passing to extractNavigationBlocks * Fix remaining 3 test assertions: change isNotNull to isInstanceOf(PathResult.Available) --------- Co-authored-by: bedaHovorka <5263405+bedaHovorka@users.noreply.github.com>

…ng (#361) * Address PR review comments: fix indentation, resource leak, test naming, and documentation --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: bedaHovorka <5263405+bedaHovorka@users.noreply.github.com>

…ments This commit addresses all 5 issues (2 Critical, 3 Major) identified in PR #358 code review: **Critical Issues:** 1. Train.kt PathResult Logic - Added explicit justification comments at 3 locations explaining why sim/ package modifications comply with conservative approach: - Type safety benefits of PathResult sealed class - Zero performance overhead (no boxing) - Physics validation references (TRAIN_PASSIVATION_FIX.md) - Comprehensive test coverage 2. hold(5.0) Polling - Added performance trade-off documentation: - Polling overhead: 0.2 wakeups/second per blocked train (acceptable) - Why passivate() was rejected (motor creeping bug) - Physics validation metrics (velocity: 8.48E-4 → 0.0 m/s) **Major Issues:** 3. MIN_INOUT_ELEMENTS Documentation - Fixed hardcoded "2" in error message: - Changed to use MIN_INOUT_ELEMENTS constant - Added note about bidirectional train operation (Issue #356) - Added regression test to verify error message accuracy 4. Lenient XML Validation - Added pre-save validation: - XMLContextFactory.saveContext() validates InOut count before serialization - MenuBar shows warning when opening invalid contexts - MenuBar shows specific error when save fails due to validation - Added 3 new tests for save rejection behavior 5. HashMapGraph Thread-Safety - Added comprehensive documentation: - Class-level KDoc explaining non-thread-safe design decision - Method-level KDoc for nodeSet() cache implementation - Usage guidelines and references to BaseContext/ContextConcurrencyTest **Testing:** - All 1912 tests passing (1 skipped, 0 failed) - 4 new tests added (1 for error message, 3 for save validation) - Code quality checks passing (detekt, ktlintCheck) **Impact:** - No breaking changes to public API - Conservative approach maintained (minimal logic changes to sim/) - Documentation-heavy changes with comprehensive validation Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

github-actions · 2026-02-07T07:54:08Z

Code Review - PR #358

Executive Summary

This PR represents a high-quality architectural enhancement. Overall Assessment: APPROVED WITH MINOR COMMENTS

Key Strengths

Conservative Simulation Core Modifications - Train.reverseDirection() follows minimal changes guideline
Type-Safe PathResult Sealed Class - Eliminates null ambiguity with zero performance overhead
Context System Architecture - Clean separation and runtime immutability enforcement
Koin DI Scope Lifecycle - Proper scope-per-context pattern with excellent documentation

Issues Found

Major (1 issue)

Engineer Delay Calculation Inconsistency (Train.kt:906-908) - Comment says 200m at 1.5 m/s but uses 30 second delay. Math shows 200m / 1.5 m/s = 133 seconds not 30. Recommendation: Fix comment to match actual delay rationale.

Medium (2 issues)

Missing Single-InOut Bidirectional Test - PR introduces single-InOut support but lacks integration test
Dual Ownership Tracking Design - Properly documented as tech debt

Minor (3 issues)

Magic Number for polling interval at Train.kt:197 - Extract 5.0 to named constant
PathResult could carry diagnostic context for better debugging
No scope closure logging in DefaultSimulationContext.close()

Performance Analysis

All performance decisions validated:

5-second polling: 0.2 wakeups/second per train (acceptable)
PathResult: compile-time dispatch (zero overhead)
Animation cache: O(1) lookups vs O(n-squared) grid scans

Test Coverage

Statistics: 1840 tests (1836 passing, 4 skipped), 51% code coverage

Coverage Gaps:

No single-InOut network test (recommended)
No happy path reversible journey test (complexity noted)

CLAUDE.md Compliance

All guidelines met: Minimal sim/ changes, no refactoring, tests required, quality gates passing

Final Verdict

APPROVED - Risk Level: LOW, Breaking Changes: NONE, Backward Compatibility: FULL

Recommendation: Merge after addressing engineer delay comment. Other issues are minor enhancements.

Review by Claude Sonnet 4.5 following CLAUDE.md standards

sonarqubecloud · 2026-02-07T07:54:21Z

Quality Gate failed

Failed conditions
59.4% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

- Rename editingContextFactory to xmlContextFactory in OpenAction to avoid confusion with EditingContextFactory (reviewer comment MenuBar.kt:73) - Fix placeholder comment Issue #XXX PR #358 to Issue #80 (MenuBar.kt:103) - Rename inOutCount to inOutsCount for consistency (MenuBar.kt:202) - Rename docs/issues/issue-80.md to issue_80.md to match underscore convention - Update issue_80.md dialog text excerpt to match current implementation Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

@DisplayName

- Replace placeholder references "Issue #XXX, PR #358" with correct "Issue #80, PR #357" in XMLContextFactory.kt (both saveContext KDocs) and XMLContextFactoryOutputStreamTest.kt (@DisplayName annotation) - Delete docs/issues/issue-80.md stub (redirect to issue_80.md); README.md already links to the canonical issue_80.md file Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

- Rename editingContextFactory to xmlContextFactory in OpenAction to avoid confusion with EditingContextFactory (reviewer comment MenuBar.kt:73) - Fix placeholder comment Issue #XXX PR #358 to Issue #80 (MenuBar.kt:103) - Rename inOutCount to inOutsCount for consistency (MenuBar.kt:202) - Rename docs/issues/issue-80.md to issue_80.md to match underscore convention - Update issue_80.md dialog text excerpt to match current implementation Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

@DisplayName

- Replace placeholder references "Issue #XXX, PR #358" with correct "Issue #80, PR #357" in XMLContextFactory.kt (both saveContext KDocs) and XMLContextFactoryOutputStreamTest.kt (@DisplayName annotation) - Delete docs/issues/issue-80.md stub (redirect to issue_80.md); README.md already links to the canonical issue_80.md file Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

- Rename editingContextFactory to xmlContextFactory in OpenAction to avoid confusion with EditingContextFactory (reviewer comment MenuBar.kt:73) - Fix placeholder comment Issue #XXX PR #358 to Issue #80 (MenuBar.kt:103) - Rename inOutCount to inOutsCount for consistency (MenuBar.kt:202) - Rename docs/issues/issue-80.md to issue_80.md to match underscore convention - Update issue_80.md dialog text excerpt to match current implementation Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

@DisplayName

- Replace placeholder references "Issue #XXX, PR #358" with correct "Issue #80, PR #357" in XMLContextFactory.kt (both saveContext KDocs) and XMLContextFactoryOutputStreamTest.kt (@DisplayName annotation) - Delete docs/issues/issue-80.md stub (redirect to issue_80.md); README.md already links to the canonical issue_80.md file Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

- Rename editingContextFactory to xmlContextFactory in OpenAction to avoid confusion with EditingContextFactory (reviewer comment MenuBar.kt:73) - Fix placeholder comment Issue #XXX PR #358 to Issue #80 (MenuBar.kt:103) - Rename inOutCount to inOutsCount for consistency (MenuBar.kt:202) - Rename docs/issues/issue-80.md to issue_80.md to match underscore convention - Update issue_80.md dialog text excerpt to match current implementation Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

@DisplayName

- Replace placeholder references "Issue #XXX, PR #358" with correct "Issue #80, PR #357" in XMLContextFactory.kt (both saveContext KDocs) and XMLContextFactoryOutputStreamTest.kt (@DisplayName annotation) - Delete docs/issues/issue-80.md stub (redirect to issue_80.md); README.md already links to the canonical issue_80.md file Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

- Rename editingContextFactory to xmlContextFactory in OpenAction to avoid confusion with EditingContextFactory (reviewer comment MenuBar.kt:73) - Fix placeholder comment Issue #XXX PR #358 to Issue #80 (MenuBar.kt:103) - Rename inOutCount to inOutsCount for consistency (MenuBar.kt:202) - Rename docs/issues/issue-80.md to issue_80.md to match underscore convention - Update issue_80.md dialog text excerpt to match current implementation Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

@DisplayName

- Replace placeholder references "Issue #XXX, PR #358" with correct "Issue #80, PR #357" in XMLContextFactory.kt (both saveContext KDocs) and XMLContextFactoryOutputStreamTest.kt (@DisplayName annotation) - Delete docs/issues/issue-80.md stub (redirect to issue_80.md); README.md already links to the canonical issue_80.md file Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

- Rename editingContextFactory to xmlContextFactory in OpenAction to avoid confusion with EditingContextFactory (reviewer comment MenuBar.kt:73) - Fix placeholder comment Issue #XXX PR #358 to Issue #80 (MenuBar.kt:103) - Rename inOutCount to inOutsCount for consistency (MenuBar.kt:202) - Rename docs/issues/issue-80.md to issue_80.md to match underscore convention - Update issue_80.md dialog text excerpt to match current implementation Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

@DisplayName

- Replace placeholder references "Issue #XXX, PR #358" with correct "Issue #80, PR #357" in XMLContextFactory.kt (both saveContext KDocs) and XMLContextFactoryOutputStreamTest.kt (@DisplayName annotation) - Delete docs/issues/issue-80.md stub (redirect to issue_80.md); README.md already links to the canonical issue_80.md file Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

- Rename editingContextFactory to xmlContextFactory in OpenAction to avoid confusion with EditingContextFactory (reviewer comment MenuBar.kt:73) - Fix placeholder comment Issue #XXX PR #358 to Issue #80 (MenuBar.kt:103) - Rename inOutCount to inOutsCount for consistency (MenuBar.kt:202) - Rename docs/issues/issue-80.md to issue_80.md to match underscore convention - Update issue_80.md dialog text excerpt to match current implementation Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

@DisplayName

- Replace placeholder references "Issue #XXX, PR #358" with correct "Issue #80, PR #357" in XMLContextFactory.kt (both saveContext KDocs) and XMLContextFactoryOutputStreamTest.kt (@DisplayName annotation) - Delete docs/issues/issue-80.md stub (redirect to issue_80.md); README.md already links to the canonical issue_80.md file Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

- Rename editingContextFactory to xmlContextFactory in OpenAction to avoid confusion with EditingContextFactory (reviewer comment MenuBar.kt:73) - Fix placeholder comment Issue #XXX PR #358 to Issue #80 (MenuBar.kt:103) - Rename inOutCount to inOutsCount for consistency (MenuBar.kt:202) - Rename docs/issues/issue-80.md to issue_80.md to match underscore convention - Update issue_80.md dialog text excerpt to match current implementation Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

@DisplayName

- Replace placeholder references "Issue #XXX, PR #358" with correct "Issue #80, PR #357" in XMLContextFactory.kt (both saveContext KDocs) and XMLContextFactoryOutputStreamTest.kt (@DisplayName annotation) - Delete docs/issues/issue-80.md stub (redirect to issue_80.md); README.md already links to the canonical issue_80.md file Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

- Rename editingContextFactory to xmlContextFactory in OpenAction to avoid confusion with EditingContextFactory (reviewer comment MenuBar.kt:73) - Fix placeholder comment Issue #XXX PR #358 to Issue #80 (MenuBar.kt:103) - Rename inOutCount to inOutsCount for consistency (MenuBar.kt:202) - Rename docs/issues/issue-80.md to issue_80.md to match underscore convention - Update issue_80.md dialog text excerpt to match current implementation Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

@DisplayName

- Replace placeholder references "Issue #XXX, PR #358" with correct "Issue #80, PR #357" in XMLContextFactory.kt (both saveContext KDocs) and XMLContextFactoryOutputStreamTest.kt (@DisplayName annotation) - Delete docs/issues/issue-80.md stub (redirect to issue_80.md); README.md already links to the canonical issue_80.md file Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

bedaHovorka self-assigned this Feb 6, 2026

bedaHovorka changed the base branch from develop to feature/test_cleanup February 6, 2026 04:23

bedaHovorka marked this pull request as ready for review February 6, 2026 04:24

This comment was marked as outdated.

Sign in to view

This comment was marked as resolved.

Sign in to view

Copilot AI mentioned this pull request Feb 6, 2026

Reduce minimum InOut requirement from 2 to 1 after bidirectional train support #359

Merged

6 tasks

This comment was marked as resolved.

Sign in to view

Copilot AI mentioned this pull request Feb 6, 2026

Fix Detekt failures: remove unused imports and migrate to PhysicsConstants #360

Merged

This comment was marked as outdated.

Sign in to view

bedaHovorka commented Feb 6, 2026

View reviewed changes

This comment was marked as resolved.

Sign in to view

bedaHovorka force-pushed the feature/backlog_2026_02 branch from de72648 to 5a741a4 Compare February 6, 2026 11:08

bedaHovorka requested a review from Copilot February 7, 2026 04:28

Copilot started reviewing on behalf of bedaHovorka February 7, 2026 04:29 View session

This comment was marked as resolved.

Sign in to view

Copilot AI mentioned this pull request Feb 7, 2026

Address PR review feedback: fix indentation, resource leak, test naming #361

Merged

This comment was marked as outdated.

Sign in to view

bedaHovorka changed the title ~~Feature/backlog 2026 02~~ February 2026 Feature Freeze - Backlog Completion Feb 7, 2026

bedaHovorka changed the base branch from feature/test_cleanup to main February 7, 2026 05:42

bedaHovorka changed the base branch from main to develop February 7, 2026 05:43

Copilot AI and others added 6 commits February 7, 2026 07:54

Implement modifiable EntrySet with remove, removeAll, retainAll, and …

388e1f5

…clear operations (#338) Co-authored-by: bedaHovorka <5263405+bedaHovorka@users.noreply.github.com>

bedaHovorka force-pushed the feature/backlog_2026_02 branch from 7ed71a1 to 0db384f Compare February 7, 2026 07:50

bedaHovorka merged commit aa27a49 into develop Feb 7, 2026
5 of 6 checks passed

bedaHovorka deleted the feature/backlog_2026_02 branch February 7, 2026 08:00

Copilot AI mentioned this pull request Mar 13, 2026

Add GUI pre-save validation for InOut element count #357

Merged

9 tasks

Conversation

bedaHovorka commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

February 2026 Improvements: Bidirectional Trains, Koin Testing, and Code Quality

📊 PR Summary

🚀 Key Features

1. Bidirectional Train Operation

2. Context System Improvements

3. Koin DI & Performance Testing

✅ Code Quality & API Improvements

API Enhancements

Code Quality

Data Structures & Internal Improvements

🐛 Bug Fixes

📋 Complete Issue List

✨ Key Achievements

📝 Review Notes

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as resolved.

This comment was marked as resolved.

bedaHovorka commented Feb 6, 2026

Uh oh!

Copilot AI commented Feb 6, 2026

Uh oh!

This comment was marked as resolved.

Uh oh!

Copilot AI commented Feb 6, 2026

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

bedaHovorka left a comment

Choose a reason for hiding this comment

Uh oh!

bedaHovorka commented Feb 6, 2026

Uh oh!

This comment was marked as resolved.

This comment was marked as resolved.

Uh oh!

bedaHovorka commented Feb 7, 2026

Uh oh!

Copilot AI commented Feb 7, 2026

Uh oh!

This comment was marked as outdated.

github-actions Bot commented Feb 7, 2026

Code Review - PR #358

Executive Summary

Key Strengths

Issues Found

Major (1 issue)

Medium (2 issues)

Minor (3 issues)

Performance Analysis

Test Coverage

CLAUDE.md Compliance

Final Verdict

Uh oh!

sonarqubecloud Bot commented Feb 7, 2026

Quality Gate failed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

bedaHovorka commented Feb 6, 2026 •

edited

Loading