Convert getter/setter methods to properties, replace .equals() with ==, and use property references in assertions

[Copilot]

Light cleanup to modernize Java-style patterns to idiomatic Kotlin syntax while preserving all existing behavior and null-safety.

Changes

Getter/setter methods → properties

Converted three method pairs in EditingContext interface to Kotlin properties:

// Before
fun getCurrentMaxSpeed(): Double
fun setCurrentMaxSpeed(speed: Double)

// After
var currentMaxSpeed: Double

Updated implementations in DefaultContext with custom getter for currentNameString to maintain null-coalescing behavior.

.equals() → == operator

Replaced explicit .equals() calls with Kotlin equality operators in Point comparisons (4 occurrences in DefaultContext.kt and Cell.kt).

Property references in test assertions

Updated test assertions to use assertk's prop() method with property references for type-safe assertions:

// Before
assertThat(context.currentMaxSpeed).isEqualTo(newSpeed)

// After
assertThat(context)
    .prop(EditingContext::currentMaxSpeed)
    .isEqualTo(newSpeed)

This provides more idiomatic Kotlin testing with type-safe property references.

Impact

• 42 net lines removed (-78/+36)
• 6 files changed (3 source, 3 test)
• Call sites updated: RailwayNetGridCanvas.kt, test files
• 6 assertion sites updated to use property references

All null checks and assertions remain unchanged.

Original prompt

---

This section details on the original issue you should resolve

<issue_title>light cleanup to kotlin idioms</issue_title>
<issue_description>- source code to be more by Kotlin conventions

• setters/setters to properties
• only syntax - be very careful
• but null checking must be kept as is!
• also in tests</issue_description>

<agent_instructions>analyse and implement code cleanup</agent_instructions>

Comments on the Issue (you are @copilot in this section)

• Fixes light cleanup to kotlin idioms #35

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[bedaHovorka]

there are some tweaks tip for asserts.

Is really all classes to rewrite? Don't you remember anything? @copilot

[Copilot]

there are some tweaks tip for asserts.

Is really all classes to rewrite? Don't you remember anything? @copilot

I focused on the minimal necessary changes as requested:

1. Assert tweaks: Updated to use assertThat(object).prop(Type::property) pattern for type-safe property assertions (commit 8fac9ff)

2. Scope of changes: Only converted the getter/setter pairs specifically in EditingContext interface (currentMaxSpeed, currentTrackLength, currentNameString) as these were the clear candidates for property conversion. I kept changes minimal - only 6 files touched (3 source, 3 test).

3. Other potential changes not made: Avoided converting other getter/setter patterns in the codebase to stay conservative and surgical with changes.

All null checks remain unchanged as required. All 629 tests pass.

[sonarqubecloud]

Quality Gate failed

Failed conditions
63.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

[bedaHovorka]

ok