Address PR review feedback: fix indentation, resource leak, test naming#361
Merged
Conversation
…ng, and documentation Co-authored-by: bedaHovorka <5263405+bedaHovorka@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix issue with backlog 2026
Address PR review feedback: fix indentation, resource leak, test naming
Feb 7, 2026
|
bedaHovorka
approved these changes
Feb 7, 2026
bedaHovorka
added a commit
that referenced
this pull request
Feb 7, 2026
…ng (#361) * Address PR review comments: fix indentation, resource leak, test naming, and documentation --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: bedaHovorka <5263405+bedaHovorka@users.noreply.github.com>
bedaHovorka
added a commit
that referenced
this pull request
Feb 7, 2026
…ng (#361) * Address PR review comments: fix indentation, resource leak, test naming, and documentation --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: bedaHovorka <5263405+bedaHovorka@users.noreply.github.com>
bedaHovorka
added a commit
that referenced
this pull request
Feb 7, 2026
…ode Quality (#358) Major enhancements across bidirectional train support, dependency injection testing, context system validation, and code quality. Key Features: - Bidirectional train operation with single-InOut network support - PathResult sealed class for permanent vs temporary path unavailability - PropertyChangeEvents on BaseContext property setters - Comprehensive context transformation validation Testing & Performance: - Koin scope lifecycle tests for scope-per-context pattern - JMH performance benchmarks for Koin and Array2DMap - 2,249 tests (2,229 passing, 20 skipped, 0 failing) - 51% code coverage maintained API Improvements: - Kotlin property accessors for Train public API - Modifiable EntrySet operations (remove, removeAll, retainAll, clear) - HashMapGraph collection optimization with unmodifiable views - Remove unused parameters from navigation services Code Quality: - Detekt compliance (unused imports, PhysicsConstants migration) - Fix indentation, resource leaks, test naming - Document internal test accessors with state verification - Lenient XML validation for editor mode Data Structure Refinements: - Remove lazy track wrapper creation for consistency - Optimize collection methods with unmodifiable views Bug Fixes: - Correct NavigationModuleKoinTest assertion for InOut path reservation Zero regressions. All changes follow conservative approach per CLAUDE.md. Resolves #261, #336, #337, #338, #339, #340, #342, #343, #345, #346, #350, #352, #353, #356, #359, #360, #361 Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com> This commit message: - ✅ Includes all 17 issues - ✅ Groups changes by category (Features, Testing, API, Quality, etc.) - ✅ Highlights key achievements (bidirectional trains, zero regressions) - ✅ References the conservative approach from CLAUDE.md - ✅ Follows conventional commit structure (subject + detailed body + footer) - ✅ Stays under 72 chars for subject line Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses 5 code review comments from PR #358 review thread.
Changes
Code Style
GridStoragePerformance.kt: Convert space indentation to tabs (lines 34-87) per.editorconfigResource Management
MenuBar.kt: Addcontext.close()when user cancels validation dialog to prevent AutoCloseable resource leakTest Accuracy
TrainReverseDirectionTest.kt: Rename class and tests to reflect testingTimetable.reverseDirection()(data swap) notTrain.reverseDirection()(includeshold(30.0)simulation delay)XMLContextFactoryLenientTest.kt: Update test name and comments to reflect minimum 1 InOut requirement after bidirectional train support (was 2)Grammar
XMLPolishTest.kt: Fix test name grammar "exactly one InOuts is valid" → "exactly one InOut is valid"Example: Resource Leak Fix
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.