Refactor SimulationController to callback-based lifecycle API and move EDT UI updates into Frame

[Copilot]

SimulationController previously mutated Swing UI state directly, relying on Frame as an implicit EDT boundary. This change applies the requested option 5: controller lifecycle is now UI-agnostic, and Frame owns EDT-marshalled UI projection.

• Controller boundary: lifecycle logic decoupled from Swing

  • Replaced direct ControlPanel / ToolBar / StatusBar dependencies with callbacks:
    • onStateChanged(SimulationStatus)
    • onSpeedChanged(Double)
    • onCompleted()
  • Added controller-level SimulationStatus enum (RUNNING, STOPPED) for explicit state signaling.
  • Preserved existing lifecycle semantics (sync runner start, monitor-thread completion path, stale-monitor guard).

• Frame integration: EDT-safe UI projection

  • Frame now wires controller callbacks to UI updates (ControlPanel, ToolBar, StatusBar).
  • Added a local EDT dispatch helper in Frame so callback-driven UI work is always marshalled to EDT.
  • Keeps controller reusable/testable while preserving current UI behavior.

• Test adaptation: callback-wired headless verification

  • Updated SimulationControllerTest to construct controller via callback wiring helper instead of passing Swing components directly into the controller.
  • Tests continue asserting stop button/status/toolbar/speed-indicator behavior through callback-driven UI projection.

SimulationController(
	onStateChanged = { state -> runOnEdt { /* map RUNNING/STOPPED to UI */ } },
	onSpeedChanged = { speed -> runOnEdt { statusBar.updateSpeedIndicator(speed) } },
	onCompleted = { /* completion hook */ }
)

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• download.jetbrains.com
  • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.xml/javax.xml.namespace=ALL-UNNAMED -XX:MaxMetaspaceSize=512m -XX:+HeapDumpOnOutOfMemoryError -Xmx2g -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

[bedaHovorka]

@copilot apply changes based on the comments in this thread

[Copilot]

@copilot apply changes based on the comments in this thread

Applied the requested fixes in commit 4b63ed5.

• Frame now clears simulationControlPanel.runner on STOPPED callback, so natural completion detaches the finished runner.
• SimulationController.start() now emits an initial onSpeedChanged(newRunner.speedMultiplier) after listener wiring, so preselected speed is reflected immediately.
• Added test preselectedSpeedPropagatesOnStart in SimulationControllerTest to verify initial speed projection.

Screenshot: N/A — no visual layout/UI rendering change; this is lifecycle wiring/state synchronization behavior.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
89.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud