Correct Goal 7 documentation for kDisco-based speed control#494
Merged
bedaHovorka merged 7 commits intocopilot/goal-7-simulation-speed-controlfrom May 7, 2026
Merged
Conversation
8 tasks
Copilot
AI
changed the title
[WIP] Fix LONG_TERM_GOALS.md correction for jDisco capabilities
Correct Goal 7 documentation for kDisco-based speed control
May 7, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Goal 7 (“Simulation Speed Control”) documentation in LONG_TERM_GOALS.md to correct the description of how speed control is intended to work, clarifying that the simulation engine runs in pure simulation time and that wall-clock pacing is applied externally.
Changes:
- Replaced the prior claim that the simulation library “already supports speed control” with an explanation of pure simulation-time execution.
- Documented wall-clock throttling via
SimulationRunneraroundSimulationContext.run()as the intended speed-control mechanism.
bedaHovorka
requested changes
May 7, 2026
Owner
bedaHovorka
left a comment
There was a problem hiding this comment.
add notice about that is Goal 7 completed
Contributor
Author
Added in 4732543 — Goal 7 in |
Agent-Logs-Url: https://github.com/bedaHovorka/interlockSim/sessions/377a2ef7-bc5a-45a9-a471-74d5fad657c6 Co-authored-by: bedaHovorka <5263405+bedaHovorka@users.noreply.github.com>
Agent-Logs-Url: https://github.com/bedaHovorka/interlockSim/sessions/a66e1723-36d6-4c44-8d1f-8ca5cd450ddc Co-authored-by: bedaHovorka <5263405+bedaHovorka@users.noreply.github.com>
RealTimeSynch lives in sim/ShuntingLoop.kt (not outside sim/); SimulationRunner.throttle() is the external extension point but ShuntingLoop does not call it in production. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Commit 6946b37 fixed tests 4 and 5 but missed test 2, which still had the same `val x = train != null; assertThat(x).isEqualTo(true)` pattern. Also removes unused mock variables in tests 2, 4, 5 that were never wired into assertions (`pathAhead`, `blockedTrack`, `pathBlocked`, `semaphore`, `track`, `pathUnblocked`). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
270e173 to
7142fa0
Compare
bedaHovorka
requested changes
May 7, 2026
Agent-Logs-Url: https://github.com/bedaHovorka/interlockSim/sessions/7e2018b6-a99c-4481-88ed-b1a527375dc3 Co-authored-by: bedaHovorka <5263405+bedaHovorka@users.noreply.github.com>
bedaHovorka
approved these changes
May 7, 2026
bedaHovorka
approved these changes
May 7, 2026
|
31ddfc9
into
copilot/goal-7-simulation-speed-control
10 of 12 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Goal 7 in
LONG_TERM_GOALS.mddescribed simulation speed control as a native capability of the simulation engine. This updates the goal text to reflect the current architecture and marks Goal 7 as completed.Goal 7 correction
Architecture alignment
ShuntingLoopusesRealTimeSynchinsidesim/ShuntingLoop.kt.SimulationRunner.throttle()remains the external extension point for wall-clock throttling outside the simulation engine.Goal status
**Status:** ✅ COMPLETEto Goal 7.PR scope cleanup
core/src/jvmTest/kotlin/cz/vutbr/fit/interlockSim/sim/TrainPathInteractionTest.ktso this stacked PR stays focused on the Goal 7 documentation update.