Skip to content

Correct Goal 7 documentation for kDisco-based speed control #494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bedaHovorka merged 7 commits into from
May 7, 2026
Merged

Correct Goal 7 documentation for kDisco-based speed control #494

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
cc30fc8
Initial plan
Copilot May 7, 2026
4d14ced
docs: correct Goal 7 speed control notes
Copilot May 7, 2026
2290a6d
docs: mark Goal 7 complete
Copilot May 7, 2026
62d68ba
Initial plan
Copilot May 7, 2026
5910aff
docs: correct Goal 7 speed-control implementation notes
bedaHovorka May 7, 2026
7142fa0
fix: complete always-true condition fix in TrainPathInteractionTest
bedaHovorka May 7, 2026
63082e4
test: revert unrelated TrainPathInteractionTest changes
Copilot May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion LONG_TERM_GOALS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,7 @@ Users can automatically collect key performance indicators during simulation inc
**Category:** I: System Operations
**Priority:** Critical
**Development Estimate:** 1 month
**Status:** ✅ COMPLETE

**User Value:**
Users can adjust simulation speed from slow motion (for detailed observation) to fast forward (for quick scenario completion). This provides flexibility for different use cases: slow for education, fast for research batch runs.
Expand All @@ -222,7 +223,9 @@ Users can adjust simulation speed from slow motion (for detailed observation) to
**Dependencies:** None (quick win)

**Implementation Notes:**
- kDisco already supports speed control; needs UI exposure
- The simulation library interface used by the model (historically jDisco, now kDisco/KMP) runs in pure simulation time and has no native wall-clock speed control or synchronization.
- Speed control for `ShuntingLoop` is implemented via the `RealTimeSynch` inner process inside `sim/ShuntingLoop.kt` (enabled by `enableRealTimeSync`, paced by `speedMultiplier`). This resides in the `sim/` package.
- `SimulationRunner` provides a complementary external throttling API (`throttle()`, `awaitIfPaused()`) callable from the simulation thread; this is the designed extension point for future simulation processes that delegate pacing outside the `sim/` package.
- Quick win - implement early for immediate value

---
Expand Down
Loading