improve include query param parsing and handling

Author: beeequeue

src/routes/v2/include.test-utils.ts

@@ -53,6 +53,26 @@ export const testIncludeQueryParam = (
 			expect(response.headers.get("content-type")).toContain("application/json")
 		})
 
+		test("duplicate sources (anilist,anilist,themoviedb)", async () => {
+			await db
+				.insertInto("relations")
+				.values({ anilist: 1337, thetvdb: 1337, themoviedb: 1337, imdb: "tt1337" })
+				.execute()
+
+			const query = new URLSearchParams({
+				source,
+				id: prefixify(source, "1337"),
+				include: [Source.AniList, Source.AniList, Source.TheMovieDB].join(","),
+			})
+			const response = await app.fetch(new Request(`http://localhost${path}?${query.toString()}`))
+
+			await expect(response.json()).resolves.toStrictEqual(
+				arrayify({ anilist: 1337, themoviedb: 1337 }),
+			)
+			expect(response.status).toBe(200)
+			expect(response.headers.get("content-type")).toContain("application/json")
+		})
+
 		test("all the sources", async () => {
 			await db
 				.insertInto("relations")

src/routes/v2/include.ts

@@ -2,28 +2,30 @@ import * as v from "valibot"
 
 import { db, Source, type SourceValue } from "../../db/db.ts"
 
+const allSources = Object.values(Source)
+
 export const includeSchema = v.object({
 	include: v.optional(
 		v.pipe(
 			v.string(),
 			v.regex(/^[\-a-z,]+$/, "Invalid `include` query"),
+			v.transform((value) => value.split(",")),
+			v.transform((sources) => (sources.length > 1 ? Array.from(new Set(sources)) : sources)),
 			v.minLength(1),
-			v.maxLength(200),
+			v.maxLength(allSources.length),
 		),
 	),
 })
 
 export type IncludeQuery = v.InferOutput<typeof includeSchema>
 
-const sources = Object.values(Source)
-const selectAll = sources.map((column) => db.dynamic.ref<SourceValue>(column))
-export const buildSelectFromInclude = (include: string | null | undefined) => {
+const selectAll = allSources.map((column) => db.dynamic.ref<SourceValue>(column))
+export const buildSelectFromInclude = (include: string[] | null | undefined) => {
 	if (include == null) {
 		return selectAll
 	}
 
 	return include
-		.split(",")
-		.filter((inclusion) => sources.includes(inclusion as SourceValue))
+		.filter((inclusion) => allSources.includes(inclusion as SourceValue))
 		.map((column) => db.dynamic.ref<SourceValue>(column))
 }