Skip to content

Commit 4020943

Browse files
committed
Replace every and some with includes
1 parent 3499c17 commit 4020943

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

src/db/db.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ export const NonUniqueFields = [
3434
Source.TheMovieDBSeason,
3535
Source.TheTVDB,
3636
Source.TheTVDBSeason,
37-
]
37+
] as (keyof Relation)[]
3838

3939
export type Relation = {
4040
[Source.AniDB]?: number

src/update.ts

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -68,8 +68,8 @@ const handleBadValues = <T extends string | number | undefined>(
6868

6969
// Removes duplicate source-id pairs from the list, except for thetvdb and themoviedb ids
7070
export const removeDuplicates = (entries: Relation[]): Relation[] => {
71-
const sources = (Object.values(Source) as SourceValue[]).filter((source) =>
72-
NonUniqueFields.every((field) => field !== source),
71+
const sources = (Object.values(Source) as SourceValue[]).filter(
72+
(source) => !NonUniqueFields.includes(source),
7373
)
7474
const existing = new Map<SourceValue, Set<unknown>>(sources.map((name) => [name, new Set()]))
7575

@@ -79,9 +79,7 @@ export const removeDuplicates = (entries: Relation[]): Relation[] => {
7979

8080
// Ignore nulls
8181
if (id == null) continue
82-
// Ignore sources with one-to-many relations
83-
// eslint-disable-next-line unicorn/prefer-includes
84-
if (NonUniqueFields.some((field) => field === source)) continue
82+
if (NonUniqueFields.includes(source)) continue
8583

8684
if (existing.get(source)!.has(id)) return false
8785

0 commit comments

Comments
 (0)