fix migration, improve code structure in update.ts migration runner

Author: beeequeue

src/db/db.ts

@@ -1,4 +1,4 @@
-import { mkdirSync } from "node:fs"
+import { existsSync } from "node:fs"
 
 import { createDatabase } from "db0"
 import sqlite from "db0/connectors/node-sqlite"
@@ -62,9 +62,6 @@ export interface Database {
 	relations: Relation
 }
 
-// Ensure SQLite directory exists
-mkdirSync("./dir", { recursive: true })
-
 const sqliteDb = sqlite(
 	process.env.VITEST_POOL_ID == null
 		? { path: `./db/${process.env.NODE_ENV ?? "development"}.sqlite3` }
@@ -79,6 +76,6 @@ export const db = new Kysely<Database>({
 export const migrator = new Migrator({
 	db,
 	provider: new ActuallyWorkingMigrationProvider(
-		process.env.NODE_ENV !== "test" ? "dist/migrations" : "src/migrations",
+		existsSync("src/migrations") ? "src/migrations" : "dist/migrations",
 	),
 })

src/migrations/20190611171759_initial.ts

@@ -1,6 +1,6 @@
 import { type Kysely, sql } from "kysely"
 
-export async function up(db: Kysely<any>): Promise<void> {
+export async function up(db: Kysely<unknown>): Promise<void> {
 	await sql`PRAGMA journal_mode=WAL`.execute(db)
 
 	await db.schema

src/migrations/20260124120530_schema.ts

@@ -1,35 +1,12 @@
-import { type Kysely, sql } from "kysely"
-
-export async function up(db: Kysely<any>): Promise<void> {
-	await sql`PRAGMA journal_mode=WAL`.execute(db)
-
-	await db.schema.dropTable("relations").ifExists().execute()
-
-	await db.schema
-		.createTable("relations")
-		.ifNotExists()
-
-		// Original columns
-		.addColumn("anidb", "integer", (col) => col.unique())
-		.addColumn("anilist", "integer", (col) => col.unique())
-		.addColumn("myanimelist", "integer", (col) => col.unique())
-		.addColumn("kitsu", "integer", (col) => col.unique())
-
-		// v2 columns
-		.addColumn("anime-planet", "text", (col) => col.unique())
-		.addColumn("anisearch", "integer", (col) => col.unique())
-		.addColumn("imdb", "text")
-		.addColumn("livechart", "integer", (col) => col.unique())
-		.addColumn("notify-moe", "text", (col) => col.unique())
-		.addColumn("themoviedb", "integer")
-		.addColumn("thetvdb", "integer")
-
-		// New Columns
-		.addColumn("themoviedb-season", "integer")
-		.addColumn("thetvdb-season", "integer")
-		.addColumn("animenewsnetwork", "integer", (col) => col.unique())
-		.addColumn("animecountdown", "integer", (col) => col.unique())
-		.addColumn("simkl", "integer")
-		.addColumn("media", "text")
-		.execute()
+import type { Kysely } from "kysely"
+
+export async function up(db: Kysely<unknown>): Promise<void> {
+	await db.schema.alterTable("relations").addColumn("themoviedb-season", "integer").execute()
+	await db.schema.alterTable("relations").addColumn("thetvdb-season", "integer").execute()
+	// unique, but sqlite can't add unique columns to tables
+	await db.schema.alterTable("relations").addColumn("animenewsnetwork", "integer").execute()
+	// unique, but sqlite can't add unique columns to tables
+	await db.schema.alterTable("relations").addColumn("animecountdown", "integer").execute()
+	await db.schema.alterTable("relations").addColumn("simkl", "integer").execute()
+	await db.schema.alterTable("relations").addColumn("media", "text").execute()
 }

src/update.ts

@@ -135,18 +135,9 @@ export const updateRelations = async () => {
 	log.info("update", `Removed duplicates. ${goodEntries.length} remain.`)
 
 	if (config.NODE_ENV !== Environment.Prod) {
-		const { error, results } = await migrator.migrateToLatest()
-
-		results?.forEach((it) => {
-			log.info("update", `Migration ${it.direction} "${it.migrationName}" ...`)
-			if (it.status === "Success") {
-				log.info("update", `... was executed successfully`)
-			} else if (it.status === "Error") {
-				log.error("update", `... FAILED!`)
-			}
-		})
-		if (Boolean(error) || "Error" in (results?.map((x) => x.status) || [])) {
-			throw new Error(`failed to run 'migrateToLatest' ${(error as string) || ""}`)
+		const { error } = await migrator.migrateToLatest()
+		if (error != null) {
+			throw new Error("Executing migrations failed.", { cause: error })
 		}
 	}