Update dependency @beequeue/eslint-plugin to v0.2.0 (#418)

Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Adam <adam@haglund.dev>

Author: 3 people

.eslintrc.js

@@ -11,15 +11,6 @@ module.exports = {
     'plugin:@beequeue/prettier',
   ],
   rules: {
-    'prettier/prettier': 'off',
-    'import/no-named-as-default-member': 'off',
+    'import/no-named-as-default': 'off',
   },
-  overrides: [
-    {
-      files: ['!pages/**/*.tsx', '**/*.stories.tsx'],
-      rules: {
-        'import/no-default-export': 'off',
-      },
-    },
-  ],
 }

README.md

@@ -68,8 +68,9 @@ Invalid HTTP requests have been deprecated.
 They will have a 33% chance to respond with a `400`, with a message detailing this deprecation.
 
 i.e:
+
 - Sending JSON bodies in `GET` requests
-- Sending query parameters in `POST` requests 
+- Sending query parameters in `POST` requests
 
 #### 2020-12-27
 

package.json

@@ -49,7 +49,7 @@
     "typescript": "4.2.4"
   },
   "devDependencies": {
-    "@beequeue/eslint-plugin": "0.1.3",
+    "@beequeue/eslint-plugin": "0.2.0",
     "@tsconfig/node14": "1.0.0",
     "@types/jest": "26.0.23",
     "@types/koa": "2.13.1",

src/index.ts

@@ -5,8 +5,8 @@ import { Logger } from '@/lib/logger'
 import { App } from './app'
 import { updateRelations } from './update'
 
-const { NODE_ENV } = process.env
-const port = process.env.PORT ?? 3000
+const { NODE_ENV, PORT } = process.env
+const port = PORT ?? 3000
 
 const runUpdateScript = () => updateRelations().catch(captureException)
 

src/routes/handlers/common.ts

@@ -13,6 +13,6 @@ export const sourceArray = (enumToArray(Source) as unknown) as string[]
 
 export const idSchema = Joi.number()
   .min(0)
-  .max(2147483647)
+  .max(2_147_483_647)
   .precision(0)
   .required()

src/routes/handlers/json-body.ts

@@ -41,8 +41,8 @@ export const bodyHandler = async (
   // Get relations
   relations = await knex
     .where(function () {
-      // eslint-disable-next-line @typescript-eslint/no-misused-promises
-      input.forEach((item) => this.orWhere(item))
+      // eslint-disable-next-line @typescript-eslint/no-floating-promises
+      for (const item of input) this.orWhere(item)
     })
     .from('relations')
 

src/update.ts

@@ -45,12 +45,12 @@ const regexes = {
 const formatEntry = (entry: OfflineDatabaseSchema): Relation => {
   const relation: Relation = {}
 
-  entry.sources.forEach((src) => {
+  for (const src of entry.sources) {
     const anilistMatch = regexes.anilist.exec(src)
     if (anilistMatch) {
       const id = Number(anilistMatch[1])
 
-      if (isNaN(id)) throw new Error(`${src}'s ID is not a number!!`)
+      if (Number.isNaN(id)) throw new Error(`${src}'s ID is not a number!!`)
 
       relation.anilist = id
     }
@@ -59,7 +59,7 @@ const formatEntry = (entry: OfflineDatabaseSchema): Relation => {
     if (anidbMatch) {
       const id = Number(anidbMatch[1])
 
-      if (isNaN(id)) throw new Error(`${src}'s ID is not a number!!`)
+      if (Number.isNaN(id)) throw new Error(`${src}'s ID is not a number!!`)
 
       relation.anidb = id
     }
@@ -68,7 +68,7 @@ const formatEntry = (entry: OfflineDatabaseSchema): Relation => {
     if (malMatch) {
       const id = Number(malMatch[1])
 
-      if (isNaN(id)) throw new Error(`${src}'s ID is not a number!!`)
+      if (Number.isNaN(id)) throw new Error(`${src}'s ID is not a number!!`)
 
       relation.myanimelist = id
     }
@@ -77,11 +77,11 @@ const formatEntry = (entry: OfflineDatabaseSchema): Relation => {
     if (kitsuMatch) {
       const id = Number(kitsuMatch[1])
 
-      if (isNaN(id)) throw new Error(`${src}'s ID is not a number!!`)
+      if (Number.isNaN(id)) throw new Error(`${src}'s ID is not a number!!`)
 
       relation.kitsu = id
     }
-  })
+  }
 
   return relation
 }
@@ -113,8 +113,8 @@ export const updateRelations = async () => {
           knex.batchInsert('relations', formattedEntries, 100).transacting(trx),
         ),
     )
-  } catch (e) {
-    throw new Error(e)
+  } catch (error) {
+    throw new Error(error)
   }
   Logger.info('Updated database.')
 

src/utils.ts

@@ -8,8 +8,8 @@ export const isEmpty = <
   obj: T,
 ) => {
   if (Array.isArray(obj)) {
-    return obj.length < 1
+    return obj.length === 0
   }
 
-  return Object.keys(obj).length < 1
+  return Object.keys(obj).length === 0
 }