Conversation
zinduolis
temporarily deployed
to
Integrate Pull Request
GitHub Actions
Inactive
zinduolis
temporarily deployed
to
Integrate Pull Request
GitHub Actions
Inactive
zinduolis
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Thanks for submitting a PR! Please fill in this template where appropriate:
Category
Bug
Remediate sinatra's vulnerability
Feature/Issue Description
Q: Please give a brief summary of your feature/fix
A: Remediated sinatra vulnerability and updated the code to be compatible with Rack 3.
Q: Give a technical rundown of what you have changed (if applicable)
A: Request commands were updated and also Rack::File changed to Rack::Files.
Test Cases
Q: Describe your test cases, what you have covered and if there are any use cases that still need addressing.
A: Automated Browserstack testing pass and also physical ./install, ./beef and testing of debug modules passed.
Wiki Page
If you are adding a new feature that is not easily understood without context, please draft a section to be added to the Wiki below.