Merge pull request #2437 from aharabada/fix-null-cond-crash

bfiete · web-flow · commit d4ced1bbc7a9 · 2026-05-19T16:48:03.000-07:00
Fix compiler crash when evaluating null-conditional assignment to splattable value-type
diff --git a/IDEHelper/Compiler/BfModule.cpp b/IDEHelper/Compiler/BfModule.cpp
@@ -9357,7 +9357,7 @@ BfTypedValue BfModule::FlushNullConditional(BfTypedValue result, bool ignoreNull
 
 		// Now that we have the nullableTypedValue we can set that, or just jump if we didn't need it
 		mBfIRBuilder->SetInsertPoint(notNullBB);
-		result = LoadValue(result);
+		result = LoadOrAggregateValue(result);
 		if (nullableTypedValue)
 		{
 			auto elementType = nullableType->GetUnderlyingType();

Original file line number	Diff line number	Diff line change
`@@ -9357,7 +9357,7 @@ BfTypedValue BfModule::FlushNullConditional(BfTypedValue result, bool ignoreNull`
`9357`	`9357`
`9358`	`9358`	`// Now that we have the nullableTypedValue we can set that, or just jump if we didn't need it`
`9359`	`9359`	`mBfIRBuilder->SetInsertPoint(notNullBB);`
`9360`		`- result = LoadValue(result);`
	`9360`	`+ result = LoadOrAggregateValue(result);`
`9361`	`9361`	`if (nullableTypedValue)`
`9362`	`9362`	`{`
`9363`	`9363`	`auto elementType = nullableType->GetUnderlyingType();`